added debian directory

[umarbrowser]

Added debian directory contain the source for building a debian installable package.

[liadomide]

The bug you mention does not seem to have corect answers in its description. We should spend a bit more atention with it. What other Steps were done besides this PR, and the bug you mention?

[umarbrowser]

Yes i just received a feedback from neurodebian developer here Looking at the extended list of warnings about .js files -- I guess they are all minimized versions. For Debian proper there should be "source" file and minimization should happen during package build time. I know it sounds like too much, but imagine that you need to patch any of those?

so do you have sources for those or may be there is already a debian package providing them (e.g. for all the jquery files) -- then you better just use system wide installed versions and depend on the corresponding debian packages. That would also help you to avoid listing copyright/license terms for ALL of those (ATM not done) within debian/copyright ;) You can use 'licensecheck' tool to detect files which you might have missed from debian//copyright

description for the package should be a complete sentence/paragraph, so tune up the

including a plugable workflow manager,a data persistence layer (with a relational DB and File Storage),an HTML5 based user interface, visualizers for neuro-science related entities

debhelper (debian/compat) version (here an in others): unless you really need some features from the most recent version, you might want to go back a bit from 11, so it would be possible to backport it more easily. E.g. to at least 10 . But if not -- that is ok too

https://mentors.debian.net/package/tvb-library

adjust description:

Description: most important scientific contribution of TVB Project TVB Scientific Library comes in two major forms for code-contributors as a light-weight Python library, or plugged into TVB framework (including Web interface and Persistence of data layers), Depending on your needs and resources, you could use any of the two available options for contributing and testing new code

Since all the packages are just integral parts of the TVB, I would recommend to use the same description for all the packages + adding a short summary at the end what is specific about this particular package e.g.

Description: ... -- core libraries ... . This package provides core libraries used by the TVB project.

tests:

    $> cat debian/tests/control
    Test-Command: python -m "import library"
    Depends: python

so it ships "library" module???? (I've not tried to build/test yet)

https://mentors.debian.net/package/tvb-gdist https://mentors.debian.net/package/tvb-data

will look later on... Cheers

On Tue, Jul 3, 2018 at 8:09 PM Lia Domide notifications@github.com wrote:

The bug you mention does not seem to have corect answers in its description. We should spend a bit more atention with it. What other Steps were done besides this PR, and the bug you mention?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/the-virtual-brain/tvb-geodesic/pull/17#issuecomment-402263283, or mute the thread https://github.com/notifications/unsubscribe-auth/APvBtily6t5SakTSwCNlBu1FqIFcMDBBks5uC8GAgaJpZM4U-TAS .

[liadomide]

This is feedback about TVB-framework. We should not mix these. TVB-gdist has No js files.

[umarbrowser]

Ok mentor.

[umarbrowser]

What i will to to fix the tvb-gdist issue

[umarbrowser]

OK mentor On Jul 4, 2018 5:51 PM, "Lia Domide" notifications@github.com wrote:

@liadomide commented on this pull request.

In debian/control https://github.com/the-virtual-brain/tvb-geodesic/pull/17#discussion_r200174615 :

• the virtual brain is a framework for the simulation of the dynamics
• of large-scale brain networks with biologically realistic connectivity.
• the virtual brain uses tractographic data (DTI/DSI) to generate connectivity
• .
• matrices and build cortical and subcortical brain networks the connectivity
• matrix defines the connection strengths and time delays via signal transmission
• between all network nodes.various neural mass models are available in the
• repertoire of the virtual brain and define the dynamics of a network node.
• together, the neural mass models at the network nodes and the connectivity
• matrix define the Virtual Brain.
• .
• Description: ... -- C++ libraries
• this package is a Cython interface to a C++ library for computing geodesic
• distance which is the length of shortest line between two vertices on a
• triangulated mesh in three dimensions, such that the line lies on the surface.
• .

Now the description is much worse. It does not make sense in english. Please leave it as before.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/the-virtual-brain/tvb-geodesic/pull/17#pullrequestreview-134439036, or mute the thread https://github.com/notifications/unsubscribe-auth/APvBtj1RvDNSjqcXD1P7NqHeNdgsHFN9ks5uDPKjgaJpZM4U-TAS .

[umarbrowser]

Fixed

On Thu, Jul 5, 2018 at 9:54 AM Lia Domide notifications@github.com wrote:

@liadomide commented on this pull request.

In debian/copyright https://github.com/the-virtual-brain/tvb-geodesic/pull/17#discussion_r200277700 :

@@ -0,0 +1,31 @@ +Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ +Upstream-Name https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/+Upstream-Name: tvb-library +Upstream-Contact: TVB TEAM tvb.admin@thevirtualbrain.org +Source: https://github.com/the-virtual-brain/tvb-library

in lines 2-4 a mistake is made, by using name 'tvb-library' instead of 'tvb-gdist'. Pls also check other similar files in the other open PRs

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/the-virtual-brain/tvb-geodesic/pull/17#pullrequestreview-134559834, or mute the thread https://github.com/notifications/unsubscribe-auth/APvBtsHwkac9W8WXbomy-JQsHVgJaVN4ks5uDdRMgaJpZM4U-TAS .