search

the-virtual-brain / tvb-gdist

Geodesic Library (adaptation by TVB Team)
Other
48 stars 30 forks source link

Use unique_ptr instead of auto_ptr #33

Closed ayan-b closed 4 years ago

ayan-b commented 4 years ago

auto_ptr is deprecated.

ayan-b commented 4 years ago

Looks like Cython in Python 2.7 only works with MSVS 2008, this it won't be compatible with C++14. Maybe we should drop Windows Python 2.7 build from the CI configuration.

liadomide commented 4 years ago

As tvb-library is only py3 compatible, for us it would be ok to drop Python2 support in tvb-gdist also.

ayan-b commented 4 years ago

Dropped Python 2.7 from CI in ee47a56.

liadomide commented 4 years ago

@ayan-b can we then we merge this, or would you like to add some more changes here?

ayan-b commented 4 years ago

@ayan-b can we then we merge this, or would you like to add some more changes here?

It's ok to merge now.