search

the-virtual-brain / tvb-root

Main TVB codebase
https://thevirtualbrain.org
Other
121 stars 99 forks source link

Corrected stimulus preparation and update for cosimulator.py #672

Open dionperd opened 1 year ago

dionperd commented 1 year ago

I moved the _prepare_stimulus() method call to the configuration of the CoSimulator, because during co-simulation the simulation_length is modified and equalized with the synchronization_time, leading to an erroneous reconfiguration of the stimulus in time.

I added an _current_stimulus property to the CoSimulator, in order to keep the stimulus between calles to call() method.

I also overwrote the _loop_update_stimulus method to use

stim_step=step-1

instead of stim_step=step-(current_step+1)

because current_step is updated evey synchronization time at each call().

maedoc commented 3 months ago

hi @dionperd, I'm a bit late for this one. still relevant for merging? will you rebase as Lia suggested?