search

the-virtual-brain / tvb-root

Main TVB codebase
https://thevirtualbrain.org
Other
123 stars 105 forks source link

[WIP] download entities from zenodo and removing tvb_data dependacies #682

Closed abhi-glitchhg closed 1 year ago

abhi-glitchhg commented 1 year ago

do not merge: pr to monitor changes

liadomide commented 1 year ago

An on this PR, as well as in your personal fork, the automated test pipeline will not work. Can you please work (or bring your latest code) in the tvb-root branch TVB-1999-deo ?

...or, could it be that you know a solution on how to configure the pipeline on such scenarios to still run ?

abhi-glitchhg commented 1 year ago

Do you mean running the tests on open PRs?

If yes, then i think we can enable them with github workflows.

https://github.com/the-virtual-brain/tvb-root/blob/a07670b34ed35998154156d5d36aba20d74be933/.github/workflows/build.yml#L2

We can update the above line with : 

on:
  pull_request:
  push:

This change will trigger the ci whenever there is a push or PR to the GitHub repo.

Can you please work (or bring your latest code) in the tvb-root branch TVB-1999-deo

sure

liadomide commented 1 year ago

Let us try it here in build.yml

on:
  pull_request:
  push:
liadomide commented 1 year ago

I saw the new #691 Does it mean that this one is obsolete and it should be closed ?

abhi-glitchhg commented 1 year ago

I saw the new #691 Does it mean that this one is obsolete and it should be closed ?

Yes; i will close this.