Closed liadomide closed 1 year ago
numexpr.evaluate implementation slightly changed in the latest release 2.8.5. Here https://github.com/pydata/numexpr/blob/master/numexpr/necompiler.py#L985 is no longer considering the global_dict values, just the local_dict (2nd positional arg). Code from the prev release 2.8.4 is here: https://github.com/pydata/numexpr/blob/ec5e90886b021558e51e35870735e7a64500c59e/numexpr/necompiler.py#L819
numexpr.evaluate
global_dict
local_dict
I propose to leave the call towards RefBase.evaluate only in the base Equation.evaluate implementation, if possible - like in this PR - for simplicity in fixing future similar API changes.
RefBase.evaluate
Equation.evaluate
numexpr.evaluateimplementation slightly changed in the latest release 2.8.5. Here https://github.com/pydata/numexpr/blob/master/numexpr/necompiler.py#L985 is no longer considering theglobal_dictvalues, just thelocal_dict(2nd positional arg). Code from the prev release 2.8.4 is here: https://github.com/pydata/numexpr/blob/ec5e90886b021558e51e35870735e7a64500c59e/numexpr/necompiler.py#L819I propose to leave the call towards
RefBase.evaluateonly in the baseEquation.evaluateimplementation, if possible - like in this PR - for simplicity in fixing future similar API changes.