the-virtual-brain / tvb-root

Main TVB codebase
https://thevirtualbrain.org
Other
121 stars 99 forks source link

EBR-30: Notify new TVB releases into EBRAINS KG #713

Closed AdrianValentinCiu closed 2 months ago

AdrianValentinCiu commented 4 months ago

Considered:

apdavison commented 2 months ago

The use of servicemeta is experimental for us (EBRAINS Curation team), so we might get back to you with change requests once this is deployed, but as far as I can see this looks good.

apdavison commented 2 months ago

It is a bit odd, to have these JSON files in the code with the hard-coded version number and details, and the need to have 2 of them (one for the Software and one for the WebService)

Depending on your build process, perhaps you could reduce duplication by generating the servicemeta from the codemeta with some kind of diff?