search

the-vision / jarvis-core

The core of Just A Rather Very Intelligent System!
https://gitpod.io/#https://github.com/the-vision/jarvis-core/
MIT License
18 stars 22 forks source link

Added new intent: currency #64

Closed adityabisoi closed 4 years ago

adityabisoi commented 4 years ago

Closes #60

Currency intent added, with tests.

@TeAmP0is0N Please review this. Let me know if any additional changes are needed.

swapagarwal commented 4 years ago

Tests are failing: https://travis-ci.org/github/the-vision/jarvis-core/builds/670201577

adityabisoi commented 4 years ago

@swapagarwal @TeAmP0is0N I have made the changes, the tests are passing now. Please review.

swapagarwal commented 4 years ago

@adityabisoi Please add a test case that is not present in training data. I just found out that define space works in the dictionary module but define server doesn't.

adityabisoi commented 4 years ago

@swapagarwal Can you please tell me how did you test this?

swapagarwal commented 4 years ago

Frankly, I didn't catch it in the PR stage. 😅 After merging, I was playing with the bot on Telegram and there I found some queries to be not working.