search

the-vision / jarvis-telegram

Just A Rather Very Intelligent System, now on Telegram!
https://t.me/jarvis_chatbot
MIT License
15 stars 22 forks source link

Add tests for xkcd module #14

Open swapagarwal opened 4 years ago

swapagarwal commented 4 years ago

See how the module is being called in the code and write tests accordingly. Basically see if the random comic object returned follows the expected schema. This would act as an integration test so that if anything changes in the xkcd api and the corresponding module requires updating, the test should fail!

adityabisoi commented 4 years ago

@swapagarwal @TeAmP0is0N can pytest be used as the testing framework?

swapagarwal commented 4 years ago

Yes.

adityabisoi commented 4 years ago

@TeAmP0is0N Since I am working on other issues as well, I'll work on this as soon as I solve them. I'm unassigning myself for now. Thanks.

Pihu1998 commented 4 years ago

Hi @swapagarwal @TeAmP0is0N . Is this issue up for grabs? Can I be assigned to this issue?

RohitRathore1 commented 4 years ago

@Pihu1998 Please, go ahead. :)