search

the-xkcd-community / the-red-spider-project

Coding and xkcd combined, for fun!
http://the-xkcd-community.github.com/the-red-spider-project
Other
40 stars 33 forks source link

godel command added. Mathematical formulas to Godel numbering and viceversa. #44

Closed gciruelos closed 11 years ago

jgonggrijp commented 11 years ago

Thanks for your contribution and welcome to the project! It looks very interesting.

On what platform have you tested this and how would you suggest testing it on other platforms?

I also saw a small issue while reading the code: the name of the command is godel, but in the help message the name is substituted by fortune. Probably a copy-and-paste mistake!

gciruelos commented 11 years ago

It just uses the python standard library, in fact only math.sqrt. I tested it on linux and windows, but it should work flawlessly on other platforms. About the other thing, it is indeed a copy-paste error, I will fix it asap.

gciruelos commented 11 years ago

Done. I have also explained what do the functions do to accomplish their objectives.

jgonggrijp commented 11 years ago

Great. Even if you only use the standard library there can be compatibility issues, though as you implied that shouldn't happen with math.sqrt and sys.argv. Either way it should be fine since you already tested it.