search

the-xkcd-community / the-red-spider-project

Coding and xkcd combined, for fun!
http://the-xkcd-community.github.com/the-red-spider-project
Other
40 stars 33 forks source link

Tabs or spaces #57

Open jgonggrijp opened 10 years ago

jgonggrijp commented 10 years ago

@WesleyAC wrote in #54:

Y U USE TABS? In all seriousness, we should decide if there will be any style guidelines, or if it works, it gets merged. Thoughts? See the PEP 8.

I think there is no need to establish style guidelines, and anything that works should be merged. The person who merges a pull request has the responsibility to ensure that inconsistent indentation will not be an issue. We certainly learnt our lesson with #53, #55, #56.

That said, if somebody wants to express a different opinion, here's the place.

WesleyAC commented 10 years ago

Seems fine to me, but we'll need to be careful about tab/space mixing.

lramati commented 10 years ago

I think that we should define tab/space because its a syntax element, but other than that, we could just say whatever, but I think enforcing pep8 (even if not strictly) will be better long term

jgonggrijp commented 10 years ago

I wrote:

The person who merges a pull request [operator] has the responsibility to ensure that inconsistent indentation will not be an issue.

How about making this more explicit by placing a guideline that the operator should ensure that all indentation is consistent (not mixed)?

mrhmouse commented 10 years ago

I think that requiring consistent indentation throughout a single app or file is reasonable.

jgonggrijp commented 10 years ago

I don't think this issue still requires input, but I'm adding it to the documentation milestone and leaving it open to remind us that it should be documented.