search

the3dfxdude / 7kaa

Seven Kingdoms: Ancient Adversaries - Go to the main source repository at https://sourceforge.net/projects/skfans/ for source code and builds
https://7kfans.com
Other
253 stars 72 forks source link

Manual: Tabs and spaces or just spaces? #193

Closed J-Moravec closed 4 years ago

J-Moravec commented 4 years ago

Originally discussed: https://github.com/the3dfxdude/7kaa/pull/177

Problem: Previously, there were some whitespace symbols that rendered incorrectly (i.e., rendered as a whitespace in the editor, but not as whitespace in the PDF). This was fixed with search and replace.

In some places, mix of tabs and spaces is used (i.e., tables). This doesn't have an influence on rendering, but it is still an inconsistency.

Changing all tabs into spaces would remove this inconsistency and prevent further mistakes of this kind. All white-space that is not a spacebar would be deemed as an error and removed.

Using (four) spaces instead of tabs is also a more prevalent coding style.

Solution replace all tabs into four spaces, such as: sed -i "s/\t/ /g" *.tex

the3dfxdude commented 4 years ago

Just resend this on top of the last pull request.

J-Moravec commented 4 years ago

solved by https://github.com/the3dfxdude/7kaa/pull/177/commits/f6abf5dae62b0566905d1618821a7bbbbebef7f2

the3dfxdude commented 4 years ago

Merged