Update main menu drawing and functions

the3dfxdude / 7kaa

Seven Kingdoms: Ancient Adversaries - Go to the main source repository at https://sourceforge.net/projects/skfans/ for source code and builds

https://7kfans.com

Other

253 stars 71 forks source link

Update main menu drawing and functions #234

Closed lennyhans closed 11 months ago

lennyhans commented 2 years ago

I think this could help to migrate (eventually to a dedicated or more flexible UI definition class/component)

Try to extract main menu buttons definiton

Use common button (sword ) definition
Use common function to generate the button list
Use common function to get the bitmap and use states for the changes
Extract button bitmap names to out of scope variables
Leave original comments for buttons (swords)

The menu looks the same, except for the else on #ifndef DISABLE_SINGLE_PLAYER_NEW_GAME

the3dfxdude commented 2 years ago

I think a Resource file & supporting class containing the geometry for drawing the selected graphics set UI (right now there is only one) needs to come first. If you do that I don't think you really need to handle the button behavior as its own thing inside Game. Does ButtonCustom function enough to do what the main menu needs?

Let me revisit this after release, hopefully in the next few days.

lennyhans commented 2 years ago

Yeah, I think a dedicates UI class is a must, but here I did not want to modify a lot, just a few pieces to "un-glue" the button definition from the menu events handlers. I will try to make a small (expandable) class for the menu so the UI def can be a little more decoupled

the3dfxdude commented 2 years ago

I'm not as interested in a dedicated UI class. Please look the ButtonCustom and VBrowseIF for similar menu like situations. But the cleanup portion of this request seems to be ok.

lennyhans commented 2 years ago

Well I have managed to put the CustomButton to handle the entries, but there are some leftovers (handle the highlight for example) and some errors (if I go to a training scenario all the bitmaps looks weird then I go back to the menu and it's empty) so I will try to figure it out the way. I think I get the idea

the3dfxdude commented 11 months ago

Thank you for your review of some of the basic graphics code. I have opened up a topic here: https://7kfans.com/forums/viewtopic.php?f=20&t=1291

I will be winding down github as I no longer wish to use it. Our sourceforge page has been active for a while, and I'm opening to using the resources there.