the3dfxdude / 7kaa

Seven Kingdoms: Ancient Adversaries - Go to the main source repository at https://sourceforge.net/projects/skfans/ for source code and builds
https://7kfans.com
Other
253 stars 71 forks source link

README changes and an image upload #247

Closed tmr83 closed 2 years ago

tmr83 commented 2 years ago

Hi, this pull request is not too important, but suddenly I need to focus on other things. So I am pushing these changes upstream so that they are not laying around somewhere. I tried to make the optional dependencies for building the game manual OS agnostic.

tmr83 commented 2 years ago

If you want, I can add a simple Makefile and use Autoconf, but then latex.m4 would be required, and those macros are not in the autoconf-archive package on my distro.

tmr83 commented 2 years ago

I was going to add a couple more images to this pull request when I noticed the file sizes were rather small compared to similar, older images. So please don't merge this until I sort them out.

tmr83 commented 2 years ago

Quick question: is it possible to extract images from the .res files with deresx? I tried extracting them as .bmp, but my image viewer says, "BMP image has bogus header data."

the3dfxdude commented 2 years ago

If you have m4 scripts for autoconf, then we put them into the m4 directory. Integrating the doc is definitely something that should get done.

Extracting to bmp is possible. The files in the res archive are icn (unless it is a sprite). I should have an icnbmp.c source file somewhere.

tmr83 commented 2 years ago

Please provide icnbmp.c if you have it.

I am using these macros fine:

AC_PROG_LATEX AC_PROG_PDFLATEX AC_PROG_MAKEINDEX

Unfortunately, there isn't something like them for checking to see if LaTeX packages are installed. Or maybe I am not understanding AC_LATEX_PACKAGES.

tmr83 commented 2 years ago

I am trying to wrap this PR up. I am confident the autoconf code is right, but I tried adding a --disable-doc switch because of the large size of the TeX dependencies. There are specific fonts needed to build the manual, and a couple of years ago LaTeX2e was updated where fontaxes became a build dependency. Maybe it will be repackaged into core/base later, but right now it is supplied by the latexextra package. And so, I can tell make to enter doc and all: latexmkrc, but I cannot get a make conditional for USE_DOC to work yet.

the3dfxdude commented 2 years ago

I haven't heard about any font issue from the released doc, so I must have the proper texlive extra package?

It might be better to require the user to use --enable-doc, meaning the doc will not be enabled by default. I think the distro packagers can figure out what to do if it is documented as you have in the readme, plus mention the --enable-doc switch what that will do if they provide the requirements. For casual users, texlive is kind of a big ask, so it's better not to push it by default.

If you have how make works down, then it might just be implementing the variable and the conditional in the autotools files.

tmr83 commented 2 years ago

Yes, I remember you mentioning fontaxes being missing. It took me by surprise then. You can read about the change in LaTeX2e in LaTeX2e News Issue 31, specifically under Improvements to LATEX’s font selection mechanism (NFSS).

I will try to default to not building the doc, but this is my first time to work with autoconf and make.

the3dfxdude commented 2 years ago

I send some code to your email to help on the images.

tmr83 commented 2 years ago

So, I have replaced 100+ graphics with color versions, including the three here. I am not sure if expanding this pull request with them will mess anything up. Maybe it is best to cherry pick the README changes.

the3dfxdude commented 2 years ago

OK I merged in the README changes. Please send in a rebased pull request for the image file changes. Closing.

tmr83 commented 2 years ago

I'll push them when they are all finished. Some are not as easy as others to create, and I will be trying to reduce the size of some because they give me trouble in the manual. The upgrade will be a big improvement. autoconf and make additions will come after. Also, I was given permission by Enlight to use a couple graphics to make a new cover.