the3dfxdude / 7kaa

Seven Kingdoms: Ancient Adversaries - Go to the main source repository at https://sourceforge.net/projects/skfans/ for source code and builds
https://7kfans.com
Other
253 stars 71 forks source link

Unit on small island is unable to reboard ship #254

Closed tmr83 closed 1 year ago

tmr83 commented 2 years ago

I'm not sure if this is a bug or not. I ran into this situation one time trying to hide my king after almost being destroyed. As you can see, the ship is close enough to land, but the Persian unit doesn't move.

7K64

watery commented 2 years ago

Looks like that to me. Can you upload the save file? It may help investigating it.

the3dfxdude commented 2 years ago

It's the scenario "Not all those who wonder are lost".

Based on the size and where he stands, I don't think that should have been considered a landing point.

tmr83 commented 2 years ago

Also take note that the Mughal unit is a spy. Onboard, his loyalty is 0 but is 50 on land. I didn't test it too much, but I noticed another spy with a higher loyalty being at 10 while onboard.

the3dfxdude commented 2 years ago

Spies have two loyalty numbers. One for the nation being spied on, and one real. Which should be displayed where or what it means needs to be studied. But otherwise, I don't think it actually matters anymore since there is no longer a dead give-away that the unit is a spy, except that it doesn't rebel.

the3dfxdude commented 2 years ago

Also, it is my understanding that units cannot betray on a ship anyway. So that loyalty situation really doesn't show an issue with intended gameplay.

the3dfxdude commented 1 year ago

This is probably fixed here: 0c01b24ffb5b40dac5d8ca2e95b12953044cd165

The loyalty shown by a unit in a ship is the standard unit loyalty, which if it is faked if it is a spy. This is true when stationed at any building or ship. For whatever reason, if the unit is mobile, and it is your spy, you may see your spy's true loyalty then in the side panel when selected. However, in buildings when accessing the spy menu, then you are viewing the spy's true loyalty, as well as in the Espionage report. So the only odd one is the ship. I guess the spy's true loyalty is more important for you... for reasons. So for consistency, there probably should be a spy menu when on a ship, then you can view the actual spy loyalty. When mobile, I don't know what should be shown, but I think it works fine as is.