search

the49ltd / The49.Maui.BottomSheet

.NET MAUI library used to display pages as Bottom Sheets
MIT License
331 stars 35 forks source link

Hot Reload Not Working #43

Open realchrisparker opened 1 year ago

realchrisparker commented 1 year ago

This isn't urgent but I wanted to bring up this issue. Not sure if it is possible to fix, but hot reload doesn't work for bottom sheets. This could be a visual studio/Maui issue not recognizing BottomSheet as something that is hot reload compatible.

paulvarache commented 1 year ago

I have been suffering from this as well.

After looking into it a bit, I cannot see any information on how to support this. I found a HotReload API inside MAUI and tried to use it with no results. An issue mentions this is an old API that is unused, but there are no info on how to do it.

The sheets also don' appear in the Live VisualTree. I believe they would need to be added to either the App or Window as LogicalChild, but the AddLogicalChildInternal and RemoveLogicalChildInternal method are internal, so it is inaccessible

I'll leave this open, in case anyone can provide some help

realchrisparker commented 1 year ago

I figured it wouldn't be an easy thing. Thank you for getting back to me.

vhugogarcia commented 1 year ago

It appears this will be possible to implement in .NET MAUI soon 😎. https://github.com/dotnet/maui/pull/16046

I am not sure, but I wanted to share it 🙂👍🏻

paulvarache commented 1 year ago

That is actually great news. It only made it to main yesterday, so it won't be available immediately, but I will definitely look into integrating Hot Reload and Live Visual Tree I upgrade to .net8

vhugogarcia commented 1 year ago

That is actually great news. It only made it to main yesterday, so it won't be available immediately, but I will definitely look into integrating Hot Reload and Live Visual Tree I upgrade to .net8

right! also this may be automatically fixed https://github.com/the49ltd/The49.Maui.BottomSheet/issues/23 or no. hehe!

realchrisparker commented 1 year ago

This is very good news.

hansmbakker commented 10 months ago

I guess this is possible now that #83 is merged