search

the49ltd / The49.Maui.BottomSheet

.NET MAUI library used to display pages as Bottom Sheets
MIT License
324 stars 31 forks source link

Issues with <OnPlatform/> #46

Closed EdwardMcFlurry closed 1 year ago

EdwardMcFlurry commented 1 year ago

Hi @paulvarache

Are you aware that using OnPlatform is not woking with your Plugin as I could be wrong but it requires a Type and Value but looking at your example it doesn't work on my side. Below is what I used to have different presentation of the Bottomsheet per platform.

Kindly advise as to how to go about using OnPlatofrm with the Plugin.
EdwardMcFlurry commented 1 year ago

Hi @paulvarache

Are you aware that using OnPlatform is not woking with your Plugin as I could be wrong but it requires a Type and Value but looking at your example it doesn't work on my side. Below is what I used to have different presentation of the Bottomsheet per platform.

bottomSheet:BottomSheet.Detents </bottomSheet:BottomSheet.Detents>

Kindly advise as to how to go about using OnPlatofrm with the Plugin.

@jfversluis can you perhaps know of a way to do this per platform?

paulvarache commented 1 year ago

Here is a working example:

    <the49:BottomSheet.Detents>
        <OnPlatform x:TypeArguments="the49:DetentsCollection">
            <On Platform="Android">
                <the49:DetentsCollection>
                    <the49:FullscreenDetent />
                    <the49:RatioDetent Ratio=".95" />
                    <the49:RatioDetent Ratio=".5" />
                </the49:DetentsCollection>
            </On>
            <On Platform="iOS">
                <the49:DetentsCollection>
                    <the49:FullscreenDetent />
                    <the49:RatioDetent Ratio=".95" />
                    <the49:MediumDetent />
                </the49:DetentsCollection>
            </On>
        </OnPlatform>
    </the49:BottomSheet.Detents>

I'll have the readme updated to fix the wrong example in the next release.

Let me know if that solves your issue

EdwardMcFlurry commented 1 year ago

Hi @paulvarache

Thanks as it did work however, the BIG problem on Android even from @jfversluis video is the Handle that is missing. On iOS is visible but on Android it is not although 'HasHandle="True"'.

Can you please take a look it?

EdwardMcFlurry commented 1 year ago

@paulvarache kindly take a look at this issue on Android if you got the time.

EdwardMcFlurry commented 1 year ago

Hi @paulvarache

Thanks as it did work however, the BIG problem on Android even from @jfversluis video is the Handle that is missing. On iOS is visible but on Android it is not although 'HasHandle="True"'.

Can you please take a look it?

@paulvarache, I have added the styles.xml for Android and can now confirm that the Handle shows. Thank you once again for this handful tool 👍🏻