feliciss
commented
4 years ago Pseudocode here (learned from the example cli):
wallet/wallet.go
type Account struct {
PrivateKey ed25519.PrivateKey
Address types.AccountAddress
SequenceNumber uint64
}
type Wallet struct {
Accounts map[string]*Account
}
func NewWallet() (*Wallet, error) {
wallet := &Wallet{
Accounts: make(map[string]*Account),
}
return wallet, nil
}
func (*Wallet) NewAccount() (*Account, error) {
pubkey, prikey, err := ed25519.GenerateKey(rand.Reader)
if err != nil {
return nil, err
}
hasher := sha3.New256()
hasher.Write(pubkey)
account := &Account {
PrivateKey: crypto.PrivateKey(prikey),
}
hasher.Sum(account.Address[:0])
return account, nil
}
func (*Account) GetAddress(account Account) (*string, error) {
address := hex.EncodeToString(account.Address[:])
return &address, nil
}
func (*Account) MintCoin(address string, amount uint64) error {
amountMicro := amount * 1000000
faucetURL := fmt.Sprintf("http://faucet.testnet.libra.org/?amount=%d&address=%s", amountMicro, address)
log.Printf("Going to POST to faucet service: %s", faucetURL)
resp, err := http.PostForm(faucetURL, nil)
if err != nil {
return err
}
defer resp.Body.Close()
body, err := ioutil.ReadAll(resp.Body)
if err != nil {
return err
}
log.Printf("Respone (code=%d): %s", resp.StatusCode, string(body))
return nil
}
the729
It's a good choice to add a wallet package and related functions such as
newWallet,wallet.createAccount, and more such asclient.mintCoin. Moreover, adding a wallet also tackles the problem of the differentiation ofed25519between golang and rust. In golang, there is 64-bytes private key, whereas the libra uses 32-bytes private key (called PrivateKeySeed in golang). The private key generated from libra source code that can't be used directly to go-libra package because of the difference of key length. To eliminate the ambiguities, the choices are either to add wallet operations in golang package that would use golang's ed25519 or support the 32-bytes length private key from rust or other analogous programming languages that only produce 32-bytes private key by declaring a function likeed25519.NewKeyFromSeed().