the78mole / esphome_components

ESPhome Components from the little digger
Other
25 stars 11 forks source link

fix handling of signed values #45

Closed jensgraef closed 1 year ago

jensgraef commented 1 year ago

This pull request fixes an issue introduced in #43. Thanks for finding it, @qschneider

qschneider commented 1 year ago

Hi, i tested your fix, but it doesn't change the output. I noticed that the "negative" number is much greater than it was before you introduced signed value handling in the frist place. I used the settings below.

external_components:

and got this output

logs_esp32-km271-hz_logs.txt

jensgraef commented 1 year ago

@qschneider: Would you mind trying to add ref:fix-signed-value-handling to the definition of the external component? According to https://esphome.io/components/external_components.html that's the way how to select a certain branch.

qschneider commented 1 year ago

once you do it the right way... :-)

signed values bug is fixed, thanks!