search

the78mole / esphome_components

ESPhome Components from the little digger
Other
24 stars 11 forks source link

Fix handling of negative temperature offsets #76

Closed jensgraef closed 3 months ago

jensgraef commented 3 months ago

Fix rounding issue when setting a value leading to setting values 0.5° higher. Fix parsing issue leading to wrong values in home assistant when using negative offsets.

This PR solves #75

jensgraef commented 3 months ago

I tested this by changing HK1 offset temperatures through home assistant and verifying on the control unit of the heater and also the other way around by setting temperatures on the control unit and checking home assistant. Everything looks fine for positive values, negative values and 0.

the78mole commented 3 months ago

Wow @jensgraef, that was fast. I'll try it out now on my Buderus and will finish the review.

the78mole commented 3 months ago

Thanks @jensgraef 😘