theADAMJR / acrd.app

Chat app like old-style Discord, with custom themes and more.
https://acrd.app/
Mozilla Public License 2.0
242 stars 108 forks source link

[BUG] Themes are kind-of way too powerful... #53

Open andriemc opened 1 year ago

andriemc commented 1 year ago

Describe the bug A clear and concise description of what the bug is. Sooo. I made a theme that makes your acrd.app account unusable if you apply it.

To Reproduce Steps to reproduce the behavior:

  1. Apply theme, https://acrd.app/themes/hHLzdcJ
  2. See problem.

Screenshots If applicable, add screenshots to help explain your problem.

On an alt image

Desktop (please complete the following information):

Additional context Add any other context about the problem here. No.

andriemc commented 1 year ago

By the way. DO NOT APPLY THIS ON YOUR MAIN ACCOUNT, I REPEAT. DO NOT APPLY THIS ON YOUR MAIN ACCOUNT

andriemc commented 1 year ago

NOTE: You can fix it by dispatching this in redux devtools for your account. (You must be logged in though.)

{
  type: 'auth/updatedUser',
  payload: {
    userId: "(your userid)",
        partialUser: {
             activeThemeId: "default",
    }
  }
}

or going back in time using redux devtools then changing the theme back to normal.

theADAMJR commented 1 year ago

image

theADAMJR commented 1 year ago

There could be a keep changes prompt after changing theme, like when you change screen resolution on Windows and it auto reverts after after 15 seconds. It would have inline styles so that * { display: none; } does not break it.

theADAMJR commented 1 year ago

Also if themes were saved to localStorage, as opposed to the user, you could simply reset cookies to reverse the changes, after the user wilfully accepts the delete everything on the page theme for whatever reason, rather than needing to a new account because the page doesn't load on that account.

andriemc commented 1 year ago

image

what de hailllllllllllllll

andriemc commented 1 year ago

Also if themes were saved to localStorage, as opposed to the user, you could simply reset cookies to reverse the changes, after the user wilfully accepts the delete everything on the page theme for whatever reason, rather than needing to a new account because the page doesn't load on that account.

mhm yeah. that'd work better than using saving themes on the server rather then the client.

andriemc commented 1 year ago

You should make a official guild as well so people can talk about accord stuff & themes there

andriemc commented 1 year ago

RED.

image

theADAMJR commented 1 year ago

image image Added a built-in pure CSS theme based on https://github.com/theADAMJR/newstarsgame.com. This is what Discord doesn't allow you to do by default.