search

theAlinP / twitter-link-deobfuscator

A Firefox add-on that restores the original destination of the links (from tweets) that have been shortened by the Twitter servers. It only runs while browsing Twitter's website (twitter.com).
https://addons.mozilla.org/en-US/firefox/addon/twitter-link-deobfuscator/
MIT License
36 stars 5 forks source link

German locale #11

Closed spodermenpls closed 4 years ago

spodermenpls commented 4 years ago

A little addition for your locale folder. 😉

theAlinP commented 4 years ago

Thank you for your contribution. I will accept it, but I am trying to follow the Git workflow model called Gitflow Workflow which forbids direct commits to the master branch.

This means that I can't use the Merge button from the GitHub's web interface and I will have to perform a manual merge on the command line and that will take some time until I figure out what are the right steps according to the Gitflow Workflow.

spodermenpls commented 4 years ago

Okay, I wasn't intending to disturb your workflow, I've just wanted to make it as easy for you as possible, and since you don't have a Crowdin (or equivalents) localization account going, this is the way I did it back in the day all the time at other Github repositories. 😄

spodermenpls commented 4 years ago

Or shall I edit this pull request to use the "develop" branch as its merge target?

theAlinP commented 4 years ago

No, it's OK. That would be no good either. I will need to create a new branch and then I think I will rebase your commit on top of it. You'll know tomorrow if that works.

theAlinP commented 4 years ago

I finally did it. You can update the add-on now.

spodermenpls commented 4 years ago

Great, thanks for the shoutout!