search

theAlinP / twitter-link-deobfuscator

A Firefox add-on that restores the original destination of the links (from tweets) that have been shortened by the Twitter servers. It only runs while browsing Twitter's website (twitter.com).
https://addons.mozilla.org/en-US/firefox/addon/twitter-link-deobfuscator/
MIT License
36 stars 5 forks source link

Breaks direct messages #17

Closed FunnyInternet closed 3 years ago

FunnyInternet commented 3 years ago

DMs will not load with this extension on, I have to turn the extension off temporarily then it loads

theAlinP commented 3 years ago

The DMs load fine in my browser(s). I am also in contact with another user of the add-on and he hasn't experienced anything like that. What browser and OS are you using?

FunnyInternet commented 3 years ago

The DMs load fine in my browser(s). I am also in contact with another user of the add-on and he hasn't experienced anything like that. What browser and OS are you using?

Firefox 84.0.1, windows 10

theAlinP commented 3 years ago

I can't reproduce the issue. I encountered similar issues before and with the help of the user reporting them I found the causes and updated the add-on. Would you be willing to help in the same way?

I will guide you how to open some development tools built into the browser to look for errors and report them back to me, and then as I will gradually update the add-on, you would need to install the updated versions temporarily and tell me if the issue persists. That discussion might span over days or weeks depending on our spare time and might be too long to do it here and include information you might want to remain private so I suggest we talk through Twitter DMs. I am fully aware that currently you can't receive or send any DMs while the add-on is enabled.

FunnyInternet commented 3 years ago

Ok I can do that

theAlinP commented 3 years ago

In the past I discovered that to some countries the Twitter servers send payloads with different formats, which the add-on can't parse and crashes. I would need to obtain those responses to update the add-on to recognize the new formats.

You can find a link to my Twitter profile in my GitHub profile. Follow me so I can send you a DM to get the conversation started.

queerterpreter commented 3 years ago

I was coming to report the same broken DMs issue. Windows 10, Firefox 87.0, located in Spain but same issue with a US VPN. Enabling the add-on both disappears the messages popup in the lower right corner and produces an error when I go to the messages page.

theAlinP commented 3 years ago

@queerterpreter I created a temporary commit to fix that but I'm not completely sure of it.

To use the fix go to commit c083de9935a989c295964b3a78a1596aeac659d6, click the "Code" button then "Download ZIP". After you unzip the file on your computer open "about:debugging" in a new browser tab then click "Load Temporary Add-on...". From the new window browse to the unzipped folder and open the file "manifest.json". From this moment on the official version of the add-on will be replaced with the updated version temporarily until it is removed or the browser is restarted.

queerterpreter commented 3 years ago

This seems to fix it for me!

theAlinP commented 3 years ago

That's good to hear! I'm very close to updating the add-on from addons.mozilla.org. Until then, keep using the temporary version.

InSimpleTermsJordan commented 3 years ago

Can confirm, using Firefox Developer Edition 89.0b6 (64-bit) on Windows 10 Home 20H2 (build 19042.928) in US, the issue occurs with the current Mozilla version of the add-on and does not occur with the version listed above.

theAlinP commented 3 years ago

Can confirm, using Firefox Developer Edition 89.0b6 (64-bit) on Windows 10 Home 20H2 (build 19042.928) in US, the issue occurs with the current Mozilla version of the add-on and does not occur with the version listed above.

That's excellent news. I started adding some commits to a separate branch and in one day or two I will merge it to the master branch and release a new version.

theAlinP commented 3 years ago

I updated the version of Twitter Link Deobfuscator from addons.mozilla.org. Please update the add-on from the browser's Add-ons Manager. I will delete the temporary commit c083de9935a989c295964b3a78a1596aeac659d6 in a few days.