theAlinP / twitter-link-deobfuscator

A Firefox add-on that restores the original destination of the links (from tweets) that have been shortened by the Twitter servers. It only runs while browsing Twitter's website (twitter.com).
https://addons.mozilla.org/en-US/firefox/addon/twitter-link-deobfuscator/
MIT License
36 stars 5 forks source link

Pixiv links in the "Website" portion of profiles incorrectly redirect #19

Open biggestsonicfan opened 2 years ago

biggestsonicfan commented 2 years ago

If a user has a "Website" profile configured to link to their Pixiv account, Twitter will truncate the visual portion of the url to display "pixiv.net/member.php?id=…", however the actual link will have their Pixiv ID after the id=. The problem is, this extension was interpreting all url clicks of the profile links as "pixiv.net/member.php?id=…" literally. Some URLs which previewed correctly, however, which had the correct ID number in place, usually a "pixiv.net/fanbox/creator/1234567..." but still have the Twitter added ellipsis would literally navigate to "pixiv.net/fanbox/creator/1234567..." with the ellipsis at the end of the URL.

theAlinP commented 2 years ago

The extension doesn't interpret the link clicks, it only changes the URLs they point to, in order to restore their original destination. Clicking on the incorrect link would, unfortunately, lead you to the wrong page or to a missing one.

After a long search I found a Twitter profile (@Hitoimim) with a link like "pixiv.net/member.php?id=…", which hasn't been restored correctly.

All the links containing "pixiv.net/fanbox/creator/..." I found were restored correctly. Can you give me examples of profiles which contain this type of links which haven't been restored correctly?

biggestsonicfan commented 2 years ago

All the links containing "pixiv.net/fanbox/creator/..." I found were restored correctly. Can you give me examples of profiles which contain this type of links which haven't been restored correctly?

I only found one but I can no longer remember which twitter profile had it. All I remember is that the fanbox link also had the numbers followed by ellipsis, not "pixiv.net/fanbox/creator/..." specifically.

After a long search I found a Twitter profile (@Hitoimim) with a link like "pixiv.net/member.php?id=…", which hasn't been restored correctly.

Did you need more examples of this? I found probably a dozen. I foolishly tagged them all telling them to update their pixiv links in their profiles, as twitter sometimes nukes numbers in "php?xxxx=..." as if they were malicious links, but after realizing this was due to the extension and no action by twitter, I deleted that tweet as it was inaccurate.

theAlinP commented 2 years ago

I only found one but I can no longer remember which twitter profile had it. All I remember is that the fanbox link also had the numbers followed by ellipsis, not "pixiv.net/fanbox/creator/..." specifically.

If you ever find another one, let me know.

Did you need more examples of this? I found probably a dozen.

I found more profiles like this, but I didn't mention the others because they had NSFW content.

I foolishly tagged them all telling them to update their pixiv links in their profiles, as twitter sometimes nukes numbers in "php?xxxx=..." as if they were malicious links, but after realizing this was due to the extension and no action by twitter, I deleted that tweet as it was inaccurate.

Sorry to hear that. I hope that didn't cause you too much embarrassment.

I will notify you when I'll find a solution.

biggestsonicfan commented 2 years ago

I found more profiles like this, but I didn't mention the others because they had NSFW content.

Yeah, pixiv does get spicy like that. I probablly should have disclaimed that before you started your search. My apologies. Then again, twitter itself is not immune to lewd content on the timeline either.

Sorry to hear that. I hope that didn't cause you too much embarrassment.

Thankfully I think I caught on as to what was really happening early on, very shortly after I sent that tweet. I did send a few direct messages, however and apologized for the confusion to those artists and that their URLs were fine.

I will notify you when I'll find a solution.

I appreciate that! I very much hate url shortening, and twitter's is quite nefarious, but not nearly as bad as urx.