search

theAlinP / twitter-link-deobfuscator

A Firefox add-on that restores the original destination of the links (from tweets) that have been shortened by the Twitter servers. It only runs while browsing Twitter's website (twitter.com).
https://addons.mozilla.org/en-US/firefox/addon/twitter-link-deobfuscator/
MIT License
36 stars 5 forks source link

Twitter cards are replaced with the first link URL instead of the right one #4

Closed muellermartin closed 5 years ago

muellermartin commented 5 years ago

If a Tweet has multiple links in it, the Twitter website only shows a Twitter card for the last link. Twitter Link Deobfuscator then wrongly replaces the link of the Twitter card with the first link in the tweet instead of linking to the right one (which is the last).

Funnily, this can be observed in a tweet which I just published to advertise for Twitter Link Deobfuscator: The tweet first mentions t.co and then links to the Firefox Add-On page for Twitter Link Deobfuscator. The Twitter card shows a thumbnail and some text for the Firefox Add-On page, but if I click on it, I'm redirected to t.co instead of the Firefox Add-On page: https://twitter.com/muellermartin/status/1140602140194459648

As soon as I deactivate Twitter Link Deobfuscator, the links point to the correct location (but obviously use t.co inbetween).

theAlinP commented 5 years ago

How did I not see that already? I will get to it right away.

By the way, thanks a lot for the mention. Fortunately, everyone who didn't already install TLD will be able to reach addons.mozilla.org to install it. Unfortunately, they might then encounter this bug. I'll try to find a solution as soon as possible.

theAlinP commented 5 years ago

I fixed it. Please update your add-on.