theAndrewCline / bible-phrasing

react app for bible study
MIT License
1 stars 2 forks source link

Feature issue 3 passage selection #10

Closed jsbarrett closed 5 years ago

jsbarrett commented 5 years ago

I decided that the scope of this functionality needed to be brought down a bit, due to some of the limitations I mentioned and haven't been able to discuss further with you. (also made very little effort to make pretty as I was more concerned about functionality since we do not have a design to go off right now)

At this point, a user can select a book and a chapter and it'll be rendered to the screen.

My proposal is to add a separate issue that handles the logic for selected specific verses within a given chapter ... and (for now) not worry about having the ability to select verses across multiple chapters.

Perhaps at the top close to the nav bar we have a list of all the verse numbers (checkboxes or something?) and by default all will be selected ... and the user can then de-select verses they don't want... don't care just an idea.

The problem is the ESV API does not allow an easy way for us to know how many verses are in each chapter. An option if you really want to start with that functionality ... is allow the user to select a given chapter(s) and then we just download the whole thing and parse it on the fly in the selector to give them the list of verse numbers to select from. But that'll result in a lot of unnecessary requests being made to the API. An option around THAT problem would be to setup a middle-man api (like a graphql endpoint) and then cache requests made to the ESV api so you don't have to slam their api unnecessarily.

So those problems are not impossible to solve ... but do require more time/engineering.

I say for now ... let's work within some limitations and just get the basic functionality of a grid system and being able to drag and drop and move verses around.