theCrag / website

theCrag.com: Add your voice and help guide the development of the world's largest collaborative rock climbing & bouldering platform
https://www.thecrag.com/
110 stars 8 forks source link

Facet navigation and urls + filtering UI layout changes #1179

Closed brendanheywood closed 9 years ago

brendanheywood commented 11 years ago

This won't be for the next release, but I'd like to discuss and get some direction on the facet pages. I'm really digging the new navigation that keeps context. So if I'm looking at a list of top contributors for a node, and I click on the crumb trail, or the side menu, then I'm still looking at the contributors page for where ever I clicked.

I think the facets should also work this way but this will have a few impacts:

There are a few minor things, like we need to make 'ascents' and 'routes' etc reserved words so they can't be used in the url stub of an area.

So, pros and cons?

Todo

brendanheywood commented 11 years ago

A very quick and rough mockup

image

cgome commented 11 years ago

A big +1 from me. Facet filters are more obvious and apply filter button is more accessible.

On Friday, 16 August 2013, Brendan Heywood wrote:

A very quick and rough mockup

[image: image]https://f.cloud.github.com/assets/187449/974670/c8ab323e-065d-11e3-84c7-c225ead042cd.png

— Reply to this email directly or view it on GitHubhttps://github.com/theCrag/website/issues/1179#issuecomment-22758527 .

Campbell

scd commented 10 years ago

let's separate this into two issues. a) change the filters and b) update the urls.

I don't mind if we change our strategy with urls, that is just the nature of development. However the url issue is across all the facets, so I want to align photos so that they are all consistent. Then change them all at once.

scd commented 10 years ago

I think we could keep the facet url pretty much the same and just allow the front part of the url before (photos/routes/ascents/etc) to be interpreted as an 'at'. The old way of referencing the facets could still be allowed, in particular if we ever need multiple at's then we could use the old method.

brendanheywood commented 10 years ago

yeah I really like that, best of both worlds

scd commented 10 years ago

Now that the last facet (photos) is standardised the next step to get the facet to work after a standard index url was simple - especially given we have decided to keep the old facet url in parallel.

In repo. Try:

http://dev.thecrag.com/climbing/australia/arapiles/ascents

The '/climbing/australia/arapiles' is interpreted as an 'at' parameter.

Should work for all facets.

scd commented 10 years ago

@brendanheywood I have made changes to the template so that facets use index url context. They still work with the old urls as well.

I think this now makes your context primary navigation work with facets.

Do we need to do something similar for the climbers so that '/climber/scd/ascents' works in the same way?

brendanheywood commented 10 years ago

No, the primary driver is that we're conceptually splitting the filtering into filtering via node on the left hand menu, and via all the other filters in new controls along the top. So in a way /climber/scd/ascents is actually really /climbing/world/ascents?by=scd

brendanheywood commented 10 years ago

See also #916

brendanheywood commented 10 years ago

Add a to do related to Lee McDougal's request to tick from a search page

brendanheywood commented 9 years ago

@scd I've made some pretty good progress here with all 9 facets but I need a bit more template date to build the side menu, same data structure as we get in the listview template for children and ancestors with siblings data. There is some data already in the 'at' data and also 'referenceArea' don't care with we use. Also I if there is no 'at' node I expect it to populated with the world data, and while technically there could be multiple 'at' filters I want to just ignore that completely so only ever return one please.

scd commented 9 years ago

Please ignore my last comment about standardising for full width. I imagine you want to add child nodes to the left hand column.

If there are multiple at areas, should I return the lowest common parent?

brendanheywood commented 9 years ago

Multiple isn't really a use case I care about much and it will be hard to achieve using the ui anyway. Happy to deprecate it entirely. So just return the first one

Sent from my iPhone

On 12/10/2014, at 5:25 PM, Simon Dale notifications@github.com wrote:

Please ignore my last comment about standardising for full width. I imagine you want to add child nodes to the left hand column.

If there are multiple at areas, should I return the lowest common parent?

— Reply to this email directly or view it on GitHub https://github.com/theCrag/website/issues/1179#issuecomment-58775120.

scd commented 9 years ago

All the facets now have a referenceArea (in repo) which includes ancestors and children. If there is no at in the search then this will default to world. If there are mulitple at's then this will default to the first at.

This means multiple at's will still work, but we will only display it as if it is one at. The UI cannot generate multiple at's so it should never occur unless some advanced user explicitely wants information from multiples at's and manipulates the url. I recon we can just not worry about multiple at's but there is no need to actually deprecate it.

BTW, I think that the facet search parameters should not be included in an embed by default. If somebody is using oembed for a particular URL I think the implication is they just want the result.

brendanheywood commented 9 years ago

This is all added in to the UI now, I'm pretty happy with this now, so closing