search

theCrag / website

theCrag.com: Add your voice and help guide the development of the world's largest collaborative rock climbing & bouldering platform
https://www.thecrag.com/
109 stars 8 forks source link

reparenting annotations with other routes losing order #1351

Open scd opened 10 years ago

scd commented 10 years ago

But... new issue. In the re-parenting, all the routes got re-parented in their existing order, but the annotation (which was previously the first entry) became the last entry.

I did a quick re-test to make sure this was happening. In the test area:

http://www.thecrag.com/climbing/world/area/431130114 (a cliff)

I first created two sub-areas. (sectors) I then created three routes, R1, R2, R3 at the cliff level. I then selected R2, and inserted an annotation above. So the order in the cliff was: R1, annotation, R2, R3. I then re-parented all of the to S1. After the re-parent, they are (now) ordered: R1, R2, R3, annotation.

If there are only a couple annotations being moved around -- not too much problem to re-order them back to where they belong. But if a bunch get moved

See also: Merging routes or recursive areas destroys sorting order https://github.com/theCrag/website/issues/1455

scd commented 10 years ago

off the top of my head this may be a bit of a pain to fix, because I think it is an artifact of the API treating the reparenting of routes, areas and annotations separately. In hindsight this was probably not the right decision.

brendanheywood commented 6 years ago

+1 from support email

brendanheywood commented 6 years ago

+1 from https://github.com/theCrag/website/issues/3186

What happened?

Re-parented a junk of routes separated by annotations from one sector to another (using reparent children of selected node). All annotations ended up at the bottom of the list in the new sector, actually loosing the previously correct structure for good.

https://www.thecrag.com/climbing/united-states/colorado-shelf-road/area/16741519

screen shot 2018-05-25 at 12 57 49

What you expected:

Annotations stay where they were.

brendanheywood commented 6 years ago

+1 from support email

Mdemaillard commented 4 years ago

Ah! i got caught once, but only with 1 or 2 anotations. Since the real correction seems a lot of work, what about a warning message on the reparent process page ?

rouletout commented 4 years ago

+1 just ran into that with 4 annotations - argh

rouletout commented 2 years ago

+1 - see also here: https://github.com/theCrag/website/issues/4089