theCrag / website

theCrag.com: Add your voice and help guide the development of the world's largest collaborative rock climbing & bouldering platform
https://www.thecrag.com/
112 stars 8 forks source link

Phantom FA's in routes, an fa with no name and no date #1891

Closed brendanheywood closed 4 years ago

brendanheywood commented 9 years ago

image

Root cause is there is still a 'Diary entry' in the FA but everything else has been remove. The diary entry isn't even visible in the bulk edit so can't be delete when someone deletes everything else.

Need to fix this before we get rid of the single edit process

scd commented 9 years ago

Do we event want the diary entry stuff?

I don't want to just can it, because you had some other ideas with route history and having a comment field might be useful.

I can fix this by removing the diary entry field in the database or adding the diary entry to the bulk enter form?

brendanheywood commented 9 years ago

Keep it, add to bulk edit and relayout the bulk edit so this is under the route not to the side.

Mdemaillard commented 4 years ago

is that still possible with the new history interface of FA/FFA/Set ?

lordyavin commented 4 years ago

I delete a history entry on sandit and no phantom FA is listed.

grafik

Looks like this is fixed.

Mdemaillard commented 4 years ago

@scd i think it is your call, either try & scan the database for possible remaining phantom entries, or close the point. Searching manually these possible phantoms doesn't seem feasible with the current search: Routes tick has History sort by: FA date, ascending

but then ? can't search for empty by who

scd commented 4 years ago

If I understand the situation correctly, we can manually fix the issue if it is found on production.

Maybe it would take an hour to add a facet for searching for the phantom entries, I am really not finding an hour for anything that is not fairly high priority.

So my suggestion is to manually delete these when they are seen in the database.

Mdemaillard commented 4 years ago

ok, the bug is closed now anyway, its only data cleaning IF some wrong data is remaining. closing.