Bug with linking to stream event forum vs forum url

[brendanheywood]

ie we have a deleted stream event with forums. The forum still exists but is now effectively private and comms is continuing. I get the dailing email with a link to here:

https://www.thecrag.com/event/1031690445

which doesn't exist! Instead it should link to here:

https://www.thecrag.com/discussion/1031830353/who-is-this-guy-is-this-some-council-employee-failure-to-follow-these-laws-will-only-result-in-mo

So we need to check wether the event still exists when rendering these links OR we need to show the event summary on the forum page and continue linking to it. These two pages should be one and the same either way.

[rouletout]

Do we have more examples of that?

[brendanheywood]

The root cause here is not the private / public event, it just makes it worse in this case. The problem is that each forum is both a discussion and an event at the same time and you can do kinda similar things on the two pages but they are diverged enough to cause confusion depending on which one you end up on. In an ideal world those two pages should be merged into one and the same.

Every single discussion against a tick has this problem. Here is the first example in my dashboard:

This single comment ends up spawning 2 event pages and 1 discussion page: 1) https://www.thecrag.com/event/4309417212 2) https://www.thecrag.com/event/4304824458 3) https://www.thecrag.com/discussion/4309417164/woof-woof#m4309417164

You can also get to the same discussion on the ascent page:

4) https://www.thecrag.com/ascent/4304824395

The root cause is that when we did the analysis for the stream events I think we got it wrong, and those two events should really only be 1 event, and on top of that the discussion page should be redundant for this event type (in an ideal world)