search

theCrag / website

theCrag.com: Add your voice and help guide the development of the world's largest collaborative rock climbing & bouldering platform
https://www.thecrag.com/
112 stars 8 forks source link

New comments of private discussion in stream #2854

Open lordyavin opened 7 years ago

lordyavin commented 7 years ago

What happened? I see the new comments of "Dangerous and anti-social behaviour at Upper Slider wall on Saturday" discussion in my stream but I it is private now.

What you expected: I should not see any new comments of a private discussion in my stream.

scd commented 7 years ago

Unlinking removed it from the node but not the stream

brendanheywood commented 7 years ago

There is still the broader issue of why Kai ever saw updates to this in the first place

scd commented 7 years ago

I think because you commented and he is following you. #2853

brendanheywood commented 7 years ago

Yeah I know that's why, I'm saying the business rules are wrong. He should only see stream events which directly involve me. He should not see stream updates to a thread which I am subscribed to but he is not. He should not ever need to unwatch it because he should never have been watching it in the first place.