theCrag / website

theCrag.com: Add your voice and help guide the development of the world's largest collaborative rock climbing & bouldering platform
https://www.thecrag.com/
109 stars 8 forks source link

Streams do not accurately show edit deltas for Set / FA / FFA name date and notes #3208

Open brendanheywood opened 6 years ago

brendanheywood commented 6 years ago

What happened?

eg just trying to see the basic edit history for this discussion:

https://www.thecrag.com/discussion/1884431241/naming-for-orange-crack--brain-on-crack

Option 1) stream in the route page, filter to just edit's

https://www.thecrag.com/climbing/australia/blue-mountains/perrys-lookdown/route/313798704

Downsides:

Option 2) Old edit history page

https://www.thecrag.com/processmap/reviewdescriptionhistory/313798704

Basically useless for this use case as it doesn't show FA, or Names, aka's etc.

Option 3) Activity facet

https://www.thecrag.com/climbing/australia/blue-mountains/perrys-lookdown/route/313798704/activity

Also doesn't show what actually changed, and it is also mixed with ticks and comments and you can't filter to just edits.

What you expected:

I think the simplest would be to just flesh out the stream items slightly so that it is a more full snapshot at the point in time. Specifically I think this means:

Even this won't be a perfect snapshot but at least this will make it easier to scan through the stream and see exactly how things have been added and removed for the non-markdown content.

brendanheywood commented 6 years ago

@scd I had a go at this and have hotfixed a partial solution. I am now showing the diary markdown in the stream. There is a bug with it as it's not grabbing the latest version if you did 2+ edits and they get compressed into one stream event.

https://www.thecrag.com/event/1887269226

brendanheywood commented 5 years ago

Another example. I just split a FA history that had combined two different FA's into two different FA records. But the stream only shows 1 FA record. It also doesn't show what I actually changed, so it is neither a snapshot of current state or a transactional change.

https://www.thecrag.com/event/2702561256

https://www.thecrag.com/climbing/australia/arapiles/the-pharos/route/12920215#history

Activity log shows 3 edits but no details:

https://www.thecrag.com/climbing/australia/arapiles/the-pharos/route/12920215/activity