search

theCrag / website

theCrag.com: Add your voice and help guide the development of the world's largest collaborative rock climbing & bouldering platform
https://www.thecrag.com/
109 stars 8 forks source link

admin should be able to see all account pages #375

Closed cgome closed 12 years ago

cgome commented 12 years ago

admin should be able to see all account pages

eg when a user contacts support re a bug on their account page it is hard to review it if they have a private account

brendanheywood commented 12 years ago

yup - but it should be obvious that its a private account too

scd commented 12 years ago

I have update the system so that the 'Licensee Adminstrator' can see private accounts (in repo). However it is not clear that it is a private account so I will leave this issue open and hand over to Brendan to complete.

There is an API variable 'private => 1' which is passed to the template, so it is just a matter of making this visible.

brendanheywood commented 12 years ago

Is that ubiquitous? Ie the private accounts will appear in lots of places like the recent updates and karma but I'll mark them similar to the supporter accounts but maybe grey?

scd commented 12 years ago

Should be, unless there is a bug somewhere.

scd commented 12 years ago

I think there are actually two sub issues here.

  1. Admin should be able to see a private account home page, and that it should be clear it is a private page. Eg

http://dev.thecrag.com/climber/davidnn5

  1. There are two main privacy settings associated with an account - one determines whether the persons name can be listed in various lists and the other determines who can see the account page (kind of similar to googles permissions allowing anybody with the link to open the page). In theory if you have a private account you could be still listed in our many public lists, it's just that we should not link to the account. There may be some inconstancy in the code where private accounts are not listed in places. This is not actually an admin thingy.

I think we really only need to solve sub issue 1 to close this issue. I'm sure sub issue 2 will trigger a whole lot of discussion and take some time to work through. For example do we actually want two privacy settings. This should be done in a separate issue/discussion paper.

brendanheywood commented 12 years ago

Done - although there are a heap of template variables missing resulting in broken crumbtrail, pyramid chart, friends lists etc

I haven't added a similar treatment to the sponsor in the 'recent updates' as they aren't coming through anyway. Without these links it kinda defeats the purpose as there isn't a way to discover and link to a private person. thats fine for now though

[image: image.png]

On Mon, Nov 28, 2011 at 10:41 AM, scd < reply@reply.github.com

wrote:

http://dev.thecrag.com/climber/davidnn5

cheers Brendan

http://thecrag.com/ http://github.com/brendanheywood