search

theCrag / website

theCrag.com: Add your voice and help guide the development of the world's largest collaborative rock climbing & bouldering platform
https://www.thecrag.com/
110 stars 8 forks source link

ascents missing from pyramid #4047

Closed skomaroff closed 2 years ago

skomaroff commented 2 years ago

I have some ascents missing from my pyramid.

https://www.thecrag.com/climber/gmkwk image

On the left you can see that I have one V5 ticked. On the right, the pyramid does not have a blue mark in V5

I may have tracked down the root cause. Searching my ascents gives different results depending on whether I filter by grade.

Search with no grade filter: https://www.thecrag.com/en/climbing/united-states/lincoln-woods-state-park/area/12688855/ascents/between/2022+/by/gmkwk/?sortby=when-climbed,desc image

Search with grades filtered to VB- to V17 (a superset of the intended ascent grades): https://www.thecrag.com/en/climbing/united-states/lincoln-woods-state-park/area/12688855/ascents/with-ascent-grade/BLDV:VB-:V17/between/2022+/by/gmkwk/?sortby=when-climbed,desc image

Ascents were logged with new tick flow.

It appears that editing an ascent causes it to disappear from the a search that is filtered by grade. After taking the second screenshot above I edited the Noontime Moss ascent. It has now disappeared from that search:

image

rouletout commented 2 years ago

Thanks, we'll put that on the list to investigate before the next beta release

fritz-raphael commented 2 years ago

I can confirm @skomaroff's case: One of my ascents logged with the new tick flow doesn't appear on the route pyramid:

image image

I might have edited this ascent, but am not sure about it.

It does appear both in the Notable Ascents section of my profile, in the CPR timeline, and in all ascents with no grade filter. When I filter my ascents by grade, though, it doesn't appear:

image

And when I edit a route ticked with the new tick flow, is disappears from the route list (just tried it with another ascent).

I am aware that this information might be redundant, I just thought it might support the search for the bug and thus a possible fix =)

scd commented 2 years ago

Sorry I missed this for the last release but the bug has now been hotfixed.

However for ascents you have edited you will have to resave them for the fix to take effect.

skomaroff commented 2 years ago

I can confirm that this works after editing the missing ascents. Now to remember which ones I've edited...

skomaroff commented 2 years ago

This bug was fixed, but has reemerged sometime in the last month or so.

Compare the following two searches:

First, filtering by grade 5.0 to 5.15d https://www.thecrag.com/ascents/with-ascent-grade/YDS:5.0:5.15d/with-ascent-gear-style/trad/in-setting/natural/by/gmkwk/?sortby=when-climbed,desc image

Second, with no filter on the grade. More ascents show up. https://www.thecrag.com/ascents/with-ascent-gear-style/trad/in-setting/natural/by/gmkwk/?sortby=when-climbed,desc image

The affected ascents were logged with the new tick flow. As before, editing an ascent causes it to disappear from the first search.

scd commented 2 years ago

I have just investigated and this was a temporary bug a few releases ago. If you re-edit the missing ascents using the new tick flow then they will appear back. I just did one to demostrate.

skomaroff commented 2 years ago

Thanks for looking into this!

I can see that you fixed one tick, but editing the others myself doesn't seem to do anything.

Here's an example of a still-missing tick: https://www.thecrag.com/ascent/6414100434

scd commented 2 years ago

Weird, I wonder why it worked for one ascent.

skomaroff commented 2 years ago

I just went through all of the missing ascents and tried editing each one. Again.

The one that didn't show up yesterday does now. As far as I can tell I didn't do anything differently.

Two are still missing:

I don't see what makes them different from the 8 that did work.

scd commented 2 years ago

@skomaroff both of those ascents only have an adjectival grade. This is a different issue all together and has nothing to do with editing in the new tick flow but rather a more fundamental issue of assigning a difficulty for UK adjectival grades. The problem is with both the old tick flow and the new tick flow for both logging and editing ascents.

I have made a change which takes into account adjectival grades if no technical grades are provided. Combining British adjectival and technical grades is a difficult area which we have not got on top of yet. There is considerable work to still do here so any fix I do now is likely to be temporary.

Please note I have updated your ascents and they are now in the list.

skomaroff commented 1 year ago

Thanks @scd!

that does sound like a tricky problem to sort out!