theCrag / website

theCrag.com: Add your voice and help guide the development of the world's largest collaborative rock climbing & bouldering platform
https://www.thecrag.com/
111 stars 8 forks source link

gym sport tree and search issues #4071

Open urandom2 opened 2 years ago

urandom2 commented 2 years ago

I may well not fully understand the intended interface, but I have reviewed #3285, and am still confused. I am seeing an unexpected top rope record in my gym sport tree[0], but when I click into the line for grade 18[1], I get only top rope routes with top rope ascents and lead routes with lead ascents.

Per #3285 I have tested filtering both ascent style, tick type, and route style, but I found no top rope ascents[2] or top rope ticks for sport routes[3].

Sorry if this seems petty, but the tree line[0] was different than the linked search[1]: 11 entries in the tree vs 24 in search; and I could not manage to find the one ascent via search, so I assumed there was a bug somewhere. Also, my account should be public, but if you need screenshots for any links, let me know.

0] https://www.thecrag.com/climber/urandom#grade-profile-sport 1] https://www.thecrag.com/ascents/by/urandom/with-ascent-gear-style/sport/in-setting/artificial/has/distinctroute/with-ascent-grade/au:18:18?sortby=tick-type,desc 2] https://www.thecrag.com/ascents/with-ascent-gear-style/top-rope/?sortby=tick-type,desc 3] https://www.thecrag.com/ascents/with-ascent-grade/AU:18:18/with-tick-type/on+toprope+topropeonsight+topropeflash+topropeclean+toproperest+ropedsolo/has/distinctroute/with-route-gear-style/sport/in-setting/artificial/by/urandom/?sortby=tick-type,desc

urandom2 commented 2 years ago

looks like the issue is that I corrected the style of a route[0] without changing the ascent[1]. as such, I have a top rope route with a lead ascent type. I am unclear on the best way to disentangle these, since while most routes never change gear style, retrobolting is a thing. I guess a resolution would be to search for routes or ascents separately, but the ux may be bad?

upon further analysis, it appears you cannot change the route style of an ascent with the old edit ui. I was able to get a screenshot to show what it used to look like (after the break), because the new edit style forced everything to lineup: go new ui!

IMG_20220530_094025.jpg

0] https://www.thecrag.com/en/climbing/new-zealand/auckland/route/3092276994 1] https://www.thecrag.com/ascent/5703481419

scd commented 2 years ago

That is correct and one of the main drivers behind the new tick flow that allows for an ascent gear style that is different from the route gear style. It has been a super long time coming but very complex to to get the analysis done.

I doubt we will be fixing the old tick flow.

We have not finished the new flow yet so it will be a while before it is generally available.

On Mon., 30 May 2022, 7:48 pm Colin Arnott, @.***> wrote:

looks like the issue is that I corrected the style of a route[0] without changing the ascent[1]. as such, I have a top rope route with a lead ascent type. I am unclear on the best way to disentangle these, since while most routes never change gear style, retrobolting is a thing. I guess a resolution would be to search for routes or ascents separately, but the ux may be bad?

upon further analysis, it appears you cannot change the route style of an ascent with the old edit ui. I was able to get a screenshot to show what it used to look like (after the break), because the new edit style forced everything to lineup: go new ui!

[image: IMG_20220530_094025.jpg] https://user-images.githubusercontent.com/2526260/170964678-ee49ab41-1f93-413f-bb17-de6db151a691.jpg

0] https://www.thecrag.com/en/climbing/new-zealand/auckland/route/3092276994 1] https://www.thecrag.com/ascent/5703481419

— Reply to this email directly, view it on GitHub https://github.com/theCrag/website/issues/4071#issuecomment-1140944333, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC3CQW5XJPJXPLYKQMFEPTVMSFHBANCNFSM5WVVZ3ZQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

lordyavin commented 1 year ago

Any update on this issue @scd

scd commented 1 year ago

I started work on the filter but got distracted. I don't know when I can get back to it.