New log ascent - counting of ascents incorrect/misleading

[killakalle]

In the Release forum Simon wrote:

"If you have one attempt and it is successful then you should log 1. If you have 2 attempts and the second is successful then 2, etc."

To reproduce

1. Log a climb with the new log interface
2. Select redpoint - which is a successful ascent
3. For "Number of attempts" select 2
4. Save

Expected The confirmation modal reads: "You have 2 ascents. 1 successful and 1 failed."

Actual The confirmation modal reads: "You have 3 ascents. 1 successful and 2 failed."

Apparently, the ticked ascent, e.g. redpoint counts as 1. And the number of attempts counts as additionally failed ascents. Probably it should rather be

• Total ascents = number of attempts (or 1 if left empty)
• Failed ascents = number of attempts - 1

Link to ascent: https://www.thecrag.com/ascent/6191197554

[scd]

I have hot fixed this.

[killakalle]

@scd

I still think there is a need to clarify terminology or to update the confirmation message.

• Individual routes climbed: 2
• Attempts total: 3
• Attempts successful: 1
• Attempts failed: 2

[rouletout]

Re-opened, looks like number of attempts is not taken into account if all failed?

[scd]

@killakalle thanks for re-analysing. I have fixed this in my dev. After next release please test again.