theCrag / website

theCrag.com: Add your voice and help guide the development of the world's largest collaborative rock climbing & bouldering platform
https://www.thecrag.com/
109 stars 8 forks source link

New tick flow: Can't propose a grade if none is registered #4112

Closed lordyavin closed 9 months ago

lordyavin commented 1 year ago

I added a bunch of gym routes. All of them yet not rated officially. So I didn't register a grade but thought I can override (set) the ascent grade in the advanced fields of the new tick flow. But I can't because the UI elements are missing: grafik

You may reproduce for here: https://www.thecrag.com/en/climbing/germany/route/6526810068

What I expect:

nicHoch commented 1 year ago

i had the same problem. where i created a unknown route outdoors where i did not set a grade because of uncertainty. Was not able to set a grade feedback at logging. It will be a bit tricky to provide a good entry grade for the UI as it does not even know about the grading system so fare.

Maybe a heuristic based on the mean grad of the sector and the dominant grading system would help.

scd commented 1 year ago

FYI difficulty feedback is about providing feedback on an assigned grade. It cannot be assigned to nothing.

GrAId is designed to work off no input grades. So for a gym with not grades, as long as the routes are ticked and hopefully number attempts filled in, we will be able to suggest grades for routes.

Why not just put a grade contribution for the route.

lordyavin commented 1 year ago

Why not just put a grade contribution for the route.

It's inconvenient and what should I add as contribution if I am unsure about the grade? I don't want to update my grade contribution each time I ascended it.

The new tick UI could always contain a field to add the personal grade contribution instantly. Either a free grade selection or the grade range thing we have currently, plus a checkbox (opt in) to set this as personal grade contribution.

It's all about usability. Loading times are so bad for me, that I'm happy to switch UI as less as possible. Especially when I'm on the mobile phone.

scd commented 1 year ago

Just to confirm that this is gym routes you are talking about not outdoor routes.

I am really keen to get GrAId working for gym routes. It should not take many ascents before we can establish a grade. Once we have established the utility of GrAId in gyms we can then look at what else needs to be done.

lordyavin commented 1 year ago

No idea why GrAId is related here and the issue applies to gym and rock routes but was discovered while logging gym routes.

nicHoch commented 1 year ago

i also see that as an important function to get feedback of unknown/ungraded routes. If i see a new line bolted in a sector - but do not know who put it up or what name grad is suggested. I put it in the index (mostly with a generic name) - suggesting a grade in the moment i crate the route (sometimes i have not climed it at all) would somehow give the impression that i have done the FA. I would for sure prefer to leave a grade open for the moment and collect feedback over time. But i think it is necessary to add the route already so that it can be drawn on topos/ sorted into the list ... so that the users have an entity to discuss/log on, collect information and also grade suggestions. I mean give feedback for existing grade is very important but also we should provide an easy way to collect initial grade suggestions for new/unrated routes.

nicHoch commented 1 year ago

@lordyavin we talked about that and think that a grade feedback would not be the right approach here as there is no grade to give feedback for.

the correct way would be to use the grade override.

so the best solution from the UX point of view would be if the grade override field is not hidden in the advanced section in case that no grade is registered.

lordyavin commented 1 year ago

This issue is a gym issue. I recently noticed that I can't add a grade proposal for gym routes that have registered grades. E.g. https://www.thecrag.com/en/climbing/germany/route/6526806402

grafik

rouletout commented 1 year ago

See also https://github.com/theCrag/website/issues/4157

scd commented 10 months ago

As far as I can see you can now add difficulty feedback for gym ticking. I cannot remember when we fixed this, but closing the issue now.

lordyavin commented 10 months ago

Is not fixed for me. Just tried to log an ascent for this route https://www.thecrag.com/climbing/test-area/area/1230605421#n8387370276 but the grade selector did not show up.

scd commented 10 months ago

Ahh, I think I misinterpretted this. I thought it was about difficulty feedback. You wanted to log your own grade for your gym ascent. Sorry for missing this.

scd commented 9 months ago

Now this should be hotfixed

lordyavin commented 9 months ago

Would it be a worthy enhancement to add the option of the ticked grade as grade contribution?

killakalle commented 9 months ago

Would it be a worthy enhancement to add the option of the ticked grade as grade contribution?

@lordyavin In their current form I find the grade contributions confusing and just clutter.

Btw. there is a bug in the bulk import script of routes. Whenever you do a bulk import (with the help of an admin), the route grade is registered as the personal grade contribution of the submitter.

image