Closed killakalle closed 11 months ago
Top Rope or Second should not get any points.
@killakalle thanks for finding this one. It is definitely something that was missed. I have made some changes and released so that we should have more sensible behaviour with some of the edge cases you mentioned. I am sure that there will be subsequent issues and some in depth consultation with community.
@scd I've just re-logged the Flash ascents done in toprope and seconding. They now show fewer points than before. So, intuitively this looks good.
I've also re-logged another ascent that was Hangdog - Seconding. This one now receives more points than before. Just wondering if this is correct.
https://www.thecrag.com/ascent/6832304691
I found an old ascent of mine where I also climbed a 7a as a second and logged Hangdog. The points then were significantly lower:
https://www.thecrag.com/ascent/2684585151
@scd @rouletout Cold you please reopen this issue. The CPR currently still looks incorrect to me.
Yesterday I've climbed a 7a twice and the following points were awarded:
It looks wrong that seconding a route gets a lot higher points than leading a route.
The ascents: https://www.thecrag.com/ascent/7137608247 https://www.thecrag.com/ascent/7137657747
There is meanwhile a similar/same issue raised elsewhere: https://github.com/theCrag/website/issues/4142
Maybe related:
I've climbed the following route twice in different sessions: https://www.thecrag.com/es/escalar/spain/castellon/route/1450892985
Arguably, the lead ascent is more "valuable" than the top rope ascent. Thus the icon should show the pink point lead ascent. However, it does show the top rope flash ascent
https://www.thecrag.com/es/escalar/spain/castellon/route/1450892985/ascents/by/killakalle
Another screenshot that illustrates the problem well:
This is definitely on the list of things to fix.
I'm not sure if this is tracked elsewhere but it seems related: Second flash get misrepresented in other places, too. For instance, under Notable Ascents by Area, a second flash might show up as the hardest ascent for the area. I suppose that's intended, but there is no way of telling that it actually isn't a lead flash. Similarly, the candlestick chart for CPR indicates a hardest redpoint grade even though that grade was only achieved while seconding.
This probably has been discussed already, but overall I'm really not sure why the new tick flow records second ascents using the second tag. It seems to be causing all these bugs and problematic visualization artifacts. I appreciate that the new tick UI acknowledges the orthogonality of the lead/second/toprope axis and the onsight/flash/redpoint axis. I think I even suggested that years ago. But outside of the ticking UX itself, I feel there was never anything wrong with showing tick types like "second flash" with their own icon, instead of "flash ascent, tagged as second, but sometimes we just hide the tag so you never know".
I have fixed the dog issue. It will not apply to already logged ascents until we do a full CPR recalculation. You can force a single ascent recalculation by updating the ascent.
Yes all non trad/sport/boulder ascents in the new tick flow currently have the same CPR. This is partly because we did not do rigorous stats on these but also because we have not got around to looking at what could be a logical approach. It is not urgent because CPR outside the Trad, Sport or Boulder styles does not really do anything. There are no Second CPR charts for example.
Just so you know the plan is to look at the non-standard CPR values after we have closed down the old tick types. There are just too many moving parts right now.
For interests sake I used the new tick interface to Tick and Clone 16 different gear style / tick type ascents. Here are the results:
In the new tick flow some tick types produces wrong CPR points, while others don't produce points at all.
Reproduce
Situation A - no points assigned
Actual: In new tick flow, certain tick types are not awarded any points Expected: In new tick flow, all tick types are awarded points
Situation B - wrong points assigned
Actual: In new tick flow, Toprope Flash and LeadFlash are awarded the same points Expected: In new tick flow, Toprope flash is awarded less points than Lead Flash
Could be related to #4127