Merging of routes results in "double grade"

[killakalle]

To reproduce:

1. Merge two routes with a different grade (both routes are French sport)

2. Look at the grade of the merged route it has a "double grade" -> 6a 5+

3. Edit the route and look at the grade field (Only one of the grades is shown)

4. Save the route (without changing the grade)

5. The grade remains as a "double grade"

PS: During merging it does not offer to select one of the grades. I think this was part of the workflow in the past.

Workaround

1. Edit the route
2. Change the grade to something else and save
3. Edit the route again and set the grade it should have
4. Save

Now the correct single grade is shown.

For reference: This is the stream event https://www.thecrag.com/event/6976372443

[lordyavin]

Did this happen more than once?

[killakalle]

This happens frequently (every time?) for me.

On Wed, 28 Dec 2022 at 21:14, Kai @.***> wrote:

Did this happen more than once?

— Reply to this email directly, view it on GitHub https://github.com/theCrag/website/issues/4153#issuecomment-1366893660, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHKC5LCT62SKEEHRBTMCCK3WPSNSNANCNFSM6AAAAAATDKFCII . You are receiving this because you authored the thread.Message ID: @.***>

[lordyavin]

Can not reproduce. See https://www.thecrag.com/en/climbing/test-area/area/7049575470

My steps

1. Created test area
2. Created route 1 with grade 6a
3. Created route 2 with grade 7a
4. Merged routes and (on the preview of the merged data) changed registered grade from grade range 6a-7a to 6b+

For this scenario it worked as expected.

[lordyavin]

Tried it a third time without luck. Merge operation seams to work as expected for this artificial examples.

But I discovered,that the automatic grade conversion each user may configure does not display the grade range.

[killakalle]

To reproduce:

1. Create route 1 with grade FR 5
2. Create route 2 with grade FR 6a
3. Open route 1
4. Merge with...
5. Select route 2
6. Confirm

Result: https://www.thecrag.com/climbing/test-area/route/7065104727

[lordyavin]

Okay, I can reproduce the issue if exactly repeat your steps. Note that the error happens even if using the context menus merge entry of the route list.

I'm pretty sure the issue is cause by the French grade "5" which isn't supposed to be a valid French grade according to "Trad and sport grade systems". I believe the system recognizes the 5 as an UIAA grade for example (or any other grade context that my be valid) and adds the 5 as an alternative grade. Therefore the result of the merge does not show a grade range but a combination of to alternative grades. Why the editing UI hides this detail is beyond my imagination ;-)

@scd I recommend to close this issue as "won't fix"/"not a bug" as it looks like to be an edge case that is caused by wrong user input.

[lordyavin]

BTW: There is no way the system can automatically choose the correct French grade.

[lordyavin]

@killakalle any opinion on my last comments? Can we close the issue?

[killakalle]

@lordyavin The particular issue of merging 5+ and 6a routes is probably not that much of an issue then.

Though, there might be a bigger underlying issue with these "fake" French grades (, ..., 5, 5+). They are widely used also in guide books. So, they seem to be an accepted French grade, even though the actual grading system would require 5b or 5c.

Another place where this issue manifests is the grade feedback

[scd]

Note that theCrag has a FR grading system (6a,6a+,6b,6b+,6c,6c+) and a FR_ALT grading system (4,4+,5,5+) because both grading systems are used. However when this was encoded the thing that we did not realize is that the defacto standard at the lower grades is to use the 4, 4+ and and the higher grades use the 6c+ system. So the standard system should have been a mixture of the two grading systems and the ALT should have been the inverse.

This is super hard to fix now and requires a significant data migration work to update. Even though I would like to fix this given our resources I don't think we will be fixing this anytime soon.

[killakalle]

Fine by me to close this issue if you prefer