Open Arzorth opened 1 year ago
still not working
it only takes into account the ascents from the most frequent style (or area, not sure yet)
[tested] I changed the climbing type to TRAD and now it does not appear so:
it should take the best effort OVERALL (and probably give priority to sport over top and rock over gym)
Any advance on this? I am forced to keep the gym ascents hidden to have a decent user profile:
↑↑↑ my profile with hidden gyms ↑↑↑
↑↑↑ my profile showing all ↑↑↑
bumping some issues I consider important
Hi @lordyavin
I've mentioned in #4189 that I stopped using TheCrag for logging my ascents in my local gym because of that issue, but in reality it was more because of this one. The fact that the profile page gets glitched due to my gym top rope ascents, forces my to hide the gym ascents, disencouraging me to register them at all.
Any chances this can be reviewed?
To summarize:
Regards!
@Arzorth can you also describe what you want changed.
@scd
I've mentioned in https://github.com/theCrag/website/issues/4189 that I stopped using TheCrag for logging my ascents in my local gym because of that issue
I've also stopped logging my training ascents (indoor bouldering) because they took over my profile. I even deleted a lot of training ascents until the best grade climbed shown on the profile was again my outdoor climbing.
What I would expect:
Personally, I see indoor climbing only as a means of training for outdoor. As such, I would like my profile to show prominently my outdoor climbs - regardless how many more indoor climbs I log.
@Arzorth can you also describe what you want changed.
To be clear, we are talking about the "bigstats" section:
and "NOTABLE ASCENTS" section:
"bigstats" section takes, from the "NOTABLE ASCENTS" section, "By style" subsection, the hardest ascents of the most common style and not the hardest ascent overall.
Example: In my case, it takes the statistics from "Gym Top rope" because is the type of climbing I do the most (it is what I have in my local gym) despite having hardest ascents in "Sport". It shows: 7a+ (hardest) - 6c (onsighted) My overall: 7b (hardest) - 7a+ (onsighted)
As a minimum: "bigstats" section to show hardest ascents overall.
In my case:
to be able to select in settings if considering gym ascents for the "bigstats" 0 and 1 (hardest and onsight)
to split the "NOTABLE ASCENTS" section in outdoors and gym.
When the hardest ascent is "Gym Top rope" -> "Clean" it doesn't show a tag, only the grade: It should say "7a+ cleaned"
Actually, when the hardest ascent is "Top rope" -> "Clean" it doesn't even appear: (and things start to disappear in "NOTABLE ASCENTS": "Sport" -> "Pink point" has disappeared, for example)
Best regards
Great this gives me a better feel for what is going on. I will endevour to fix the bugs then we can discuss how we deal with the gym/training/outdoor ascent prioriitization.
I'm happy to read this, good luck!
I have found and fixed one problem.
The first stat on the left should capture the top accepted style of your first notable ascent list (by style). Currently the accepted styles are the ones we have created translation keys for, (tick redpoint pinkpoint onsight flash send solo second toprope). If it was a style like clean or greenpoint then it would have a blank translation. The bug I have fixed is to only report styles that we have the translation keys for. We can add more to the list of accepted styles for bigstats, just let me know. (note to self this is added in verb.json translation file)
What I think we want to do is make sure the first style in the notable ascents is the style that users want to see. There are two config params in your profile which allow you to control this - Preferred Setting (for Gym vs Outdoor) and Preferred Gear Style. Neither of which effect the notable ascents, but I think we should filter notable ascents to Gym or Outdoor if that is set and make the configured gear style the first style in notable ascents.
Hi @scd!
Thank you for taking the time to look into the problem, it's very much appreciated.
Let me give you my feedback on this:
Regarding the keys missing translation, I would say that the easiest thing is something like this: Clean -> cleaned Greenpoint -> greenpointed
Not sure if the current fix is the best option: the behaviour after the fix is still a bit weird (I wouldn't say weirder than the previous behaviour, but still weird, in a different way hehe), now it doesn't show the hardest route ascended, which may cause some confusion for unaware users: It is showing the 6c while ignoring the 7a+ (because it is a Clean and it doesn't have translation yet).
Therefore I would recommend: not to have Ascents without translation.
I've also marked the 7b's of "Sport" style, the ascents I would expect to see in the big stats once all bugs are solved, which bring us to the second point:
Regarding the first style, I totally agree with you on the solution proposed. Making use of the "Preferred Setting" and "Preferred Gear Style" options will make it work as users expect.
Currently the Notable Ascents are sorted by number of ascents, this criteria you proposed is much better.
Best regards and happy coding!
Btw I took the chance to play around with "Preferred Setting" and "Preferred Gear Style" options and they seem to be buggy too:
When "Natural" is selected as "Preferred Setting", the Gym sport timeline is shown first.
When "Artificial" is selected, the Sport timeline is shown first, so, they seem inverted.
I have now made notable ascents responsive to the gear style and natural/artificial setting in your profile. If you set to natural then only the outdoor ascents will appear in your profile notable ascents. This means you can log gym ascents to your hearts content without worrying about them polluting your notible ascents.
Similarily if you select a gear style then this will be your first gear style in your notible ascents.
Please log non notable ascent related bugs in another card as it will get lost here.
When can we test?
Test now on prod
When can we test?
It's already on air, but I had to re-set my preferences to see the effect, probably something to be taken into account, @scd, because most people will not do it, probably a general re-processing of the settings of all users will be too demanding, only for new logins maybe?
Thanks for fixing this problem, it means a lot for me, and probably for many people with a similar problem, just like @killakalle.
If I could add a minor comment regarding this topic: I would not hide the gym ascents from the Notable Ascents table when the option "Show ascents in settings" is set to "All", I would just show them after the Natural ascents.
But, as said, just a minor thingy.
Thanks!
Actually it might not be that little of a thingy 😅
Just noticed that this config:
Leads to this profile page:
I can agree that is a silly configuration but even tho, it should probably show the artificial ascents.
Bye!
Some time ago, my profile showed as my best ascent the 7b and as best on sight a 7a+ on-sight, during the last weeks, every time I opened my profile, the best ascent was shown as 7a (with no text) and the best on sight to 6c, then it quickly switched to the correct 7b and 7a+, now, it doesn't switch any more and it remains in 7a (with no text) and 6c on sight as you can see in the following photo: https://www.thecrag.com/climber/jositogg