theCrag / website

theCrag.com: Add your voice and help guide the development of the world's largest collaborative rock climbing & bouldering platform
https://www.thecrag.com/
109 stars 8 forks source link

Inconsistency in route tick types summary #4181

Open Arzorth opened 1 year ago

Arzorth commented 1 year ago

It looks like some ticks types are not being taken into account in route tick types summary.

This route has 1 clean tick but it is not registered in the summary of ticks:

https://www.thecrag.com/en/climbing/netherlands/the-hague/route/7257004146

image

image

scd commented 1 year ago

I have looked into this and it will be fixed from next release. Note that I have just released, which will be anounced in the next couple of days but it missed this release.

Arzorth commented 1 year ago

Fine, thanks! I will wait until next release to check this fix 👍🏼

Arzorth commented 10 months ago

Hi @scd

I've checked and it is still not fixed, I think because "Top rope clean" is not considered among the list of tick types

image

Arzorth commented 10 months ago

I'm testing in the sandpit: https://sandpit.thecrag.com/en/climbing/netherlands/the-hague/route/7257004146

Flash top rope works image

Onsight works too image

Also simple tick image

The only one not working seems to be "Clean tick" image

Just as a curiosity, Top rope solo appears just as "Top rope" image

Regards!

Arzorth commented 10 months ago

In my opinion, and making a parallelism with lead climbing, "Clean: Top rope" should appear either pink or red, as it is similar to pinkpointing or redpointing a route, but probably a different tone just to make it differentiable in the grade pyramid.

scd commented 10 months ago

The various top rope ticks are being retired. Ok only the tick types in the new tick flows will be supported.

On Thu, Aug 31, 2023, 5:55 PM José María Graciá Gómez < @.***> wrote:

I'm testing in the sandpit:

https://sandpit.thecrag.com/en/climbing/netherlands/the-hague/route/7257004146

Flash top rope works [image: image] https://user-images.githubusercontent.com/17315806/264572544-f596dc53-2fd8-4cb4-b7a4-99b3a5bf8a4d.png

Onsight works too [image: image] https://user-images.githubusercontent.com/17315806/264572865-ec72e145-fdde-4cc3-af59-557c000d0ab7.png

Also simple tick [image: image] https://user-images.githubusercontent.com/17315806/264574996-ac3315ea-9099-4f20-a046-9166d80238bf.png

The only one not working seems to be "Clean tick"

Just as a curiosity, Top rope solo appears just as "Top rope" [image: image] https://user-images.githubusercontent.com/17315806/264575646-6736aecb-29ef-45ab-964c-e5fee83e83c4.png

Regards!

— Reply to this email directly, view it on GitHub https://github.com/theCrag/website/issues/4181#issuecomment-1700544724, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC3CQTEIXUVIFONOMP2N7LXYA7PXANCNFSM6AAAAAAVN7PVEY . You are receiving this because you were mentioned.Message ID: @.***>

Arzorth commented 10 months ago

I think I don't fully understand your message, @scd , do you mean the old top rope tick types are being replaced by new ones?

scd commented 10 months ago

They are already replaced

Arzorth commented 10 months ago

But this tests have been done with the new tick system, shouldn't it work?

scd commented 10 months ago

In the new tick system you select top rope gear style and flash tick type for example

On Fri, Sep 1, 2023, 1:29 AM José María Graciá Gómez < @.***> wrote:

But this tests have been done with the new tick system, shouldn't it work?

— Reply to this email directly, view it on GitHub https://github.com/theCrag/website/issues/4181#issuecomment-1701264455, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC3CQVINTWNZ4MJMNLKZ43XYCUUBANCNFSM6AAAAAAVN7PVEY . You are receiving this because you were mentioned.Message ID: @.***>

Arzorth commented 10 months ago

ahh so, decoupling "Gear style" from "Tick type", yes, I saw it as an idea somewhere, long ago.

I think it is a great improvement, how is the development going? any target release date as beta? (no pressure, just curiosity)

regards!