search

theCrag / website

theCrag.com: Add your voice and help guide the development of the world's largest collaborative rock climbing & bouldering platform
https://www.thecrag.com/
112 stars 8 forks source link

should bulk edit replace edit for areas #534

Closed scd closed 12 years ago

scd commented 12 years ago

As per Lee's video, should we replace the easily accessible edit field with the bulk edit field?

brendanheywood commented 12 years ago

Yes if it wasn't recursive. If it was only the current area's fields + it's immediate children's routes then perhaps. I think a simpler solution is where ever there is a route table, which currently has the reorder, add route, and add topo buttons we just add a bulk edit routes button there.

I've gone ahead and done this in dev and also tidied up that set of buttons into a set.

brendanheywood commented 12 years ago

However there are probably some other things we need to clean up on that bulk edit page before it gets some main stream action:

I'd have a crack at it myself but kinda not sure where to start with that process

scd commented 12 years ago

It's all in a template.

cids/forms/bulkedit

Eventually we will move all forms to templates, but at the moment it is just the difficult ones.

You won't be able to move grade easily as it is possible to have a list of entries - eg

http://dev.thecrag.com/area/11875945

cgome commented 12 years ago

What about if when you click on 'Edit Crag' you get the current form but it includes a big button with "Edit all areas and routes at this crag" or something that launches the full Bulk Edit screen. By default this would open all fields, but maybe this full Bulk Edit screen would have an option like "I only want to edit some of these fields" (needs a better label) which would take them to the bulk edit form design screen.

On Sun, Apr 29, 2012 at 9:48 PM, scd < reply@reply.github.com

wrote:

As per Lee's video, should we replace the easily accessible edit field with the bulk edit field?

Reply to this email directly or view it on GitHub: https://github.com/theCrag/website/issues/534

Campbell

brendanheywood commented 12 years ago

To be honest I don't see much value in being able to select which fields to edit. The form should be simple and usable with all fields present.

I've made some layout changes to the form, got rid of the hover size changes, please check it out.

http://dev.thecrag.com/area/96298098

but I haven't been able to get rid of the FA comments fields without breaking the form?

brendanheywood commented 12 years ago

Ok well I was in the middle of refining the bulk edit and filling in the gaps except I've broken dev fairly badly :(

The gaps so far are:

When dev comes back to life and we fix the three above I'd be happy. However there is a downside which is if you just want to edit the area and your in a crag with heaps of data it will slow it down so perhaps there is value in both and I'll make it a button group in the header

cgome commented 12 years ago

To be honest I don't see much value in being able to select which fields to edit.

A couple of classic 'tidy up' use cases that I find really valuable:

On Mon, May 7, 2012 at 8:43 PM, Brendan Heywood < reply@reply.github.com

wrote:

Ok well I was in the middle of refining the bulk edit and filling in the gaps except I've broken dev fairly badly :(

The gaps so far are:

  • the 'approach time' is missing from bulk edit form (simon?)
  • the help descriptions are missing from bulk
  • minor layout and textarea sizing issues

When dev comes back to life and we fix the three above I'd be happy. However there is a downside which is if you just want to edit the area and your in a crag with heaps of data it will slow it down so perhaps there is value in both and I'll make it a button group in the header

Reply to this email directly or view it on GitHub: https://github.com/theCrag/website/issues/534#issuecomment-5547547

Campbell

brendanheywood commented 12 years ago

Sure, but how does removing half of the GUI help you?

When I am working through a crag, fixing stuff, even a crag that I know, it is invaluable to have the other data that I do have in context. So if the bolts field and style field are missing but the description mentions BR's then I can figure it out.

Or are you generally working through a list from somewhere else, book etc just cutting and pasting?

brendanheywood commented 12 years ago

Also:

cgome commented 12 years ago

Sure, but how does removing half of the GUI help you?

If I'm working through a crag that I know well and all I want to do is fix up all the area types I don't need to see any of the other stuff. It just gets in the way and makes the form long and cumbersome.

On Mon, May 7, 2012 at 9:36 PM, Brendan Heywood < reply@reply.github.com

wrote:

Also:

  • adding missing principal grades in current bulk edit is weird,also needs to choose the default grade system better

Reply to this email directly or view it on GitHub: https://github.com/theCrag/website/issues/534#issuecomment-5548172

Campbell

scd commented 12 years ago

Why don't we skip the first filter screen when we launch the process directly from a button on the list view page, but not skip it if you launch the process through the action pull-down tab.

That way most regular use will get straight into editing everything, while Campbell (and anybody else who wants it) can filter by going through the Action button.

cgome commented 12 years ago

Ultimately the action button will probably disappear. What about go straight to edit everything by default, but from the edit everything screen have an option to refine/filter the fields shown (could be discreet- just for sophisticated gate core users like me;))

On Thursday, May 10, 2012, scd wrote:

Why don't we skip the first filter screen when we launch the process directly from a button on the list view page, but not skip it if you launch the process through the action pull-down tab.

That way most regular use will get straight into editing everything, while Campbell (and anybody else who wants it) can filter by going through the Action button.

Reply to this email directly or view it on GitHub: https://github.com/theCrag/website/issues/534#issuecomment-5613835

Campbell

brendanheywood commented 12 years ago

Yeah I'd go with the single button and toggle the UI from inside the process

On 10/05/2012, at 1:51 PM, cgome reply@reply.github.com wrote:

Ultimately the action button will probably disappear. What about go straight to edit everything by default, but from the edit everything screen have an option to refine/filter the fields shown (could be discreet- just for sophisticated gate core users like me;))

On Thursday, May 10, 2012, scd wrote:

Why don't we skip the first filter screen when we launch the process directly from a button on the list view page, but not skip it if you launch the process through the action pull-down tab.

That way most regular use will get straight into editing everything, while Campbell (and anybody else who wants it) can filter by going through the Action button.

Reply to this email directly or view it on GitHub: https://github.com/theCrag/website/issues/534#issuecomment-5613835

Campbell

Reply to this email directly or view it on GitHub: https://github.com/theCrag/website/issues/534#issuecomment-5617612

scd commented 12 years ago

I have fixed a few things, but need to update dev database before putting it onto repo.The following has been fixed:

Tomorrow I will look at

Anything else you want me to look at for the next release to do with bulk edit.

cgome commented 12 years ago

Is it intentional that when you click on the new bulk edit link above the table it only opens up the edit screen for the nodes visible in the table (and not all their child nodes)? Should check whether that's what Lee was suggesting or did he mean that if you click on Edit or bulk edit or whatever at Arapiles it should open up the equiv of the bulk edit screen with all area and route fields selected. (That's what I thought he meant). Currently route data is inaccessible when I click 'bulk edit' unless I'm at the bottom level of the index. If you like, hold off on responding to this until I've had a look at the new 'filter fields' option when it goes up on dev. If it includes the ability to expand to include all descendants that's probably work.

Also the order of the nodes in the form is the reverse of how it appears in the table. This is confusing.

scd commented 12 years ago

Fixed the order. I changed the directives in the bulk edit area and routes table so they only edit areas/routes respectively.

The link to filter fields gives you access to all descendants.

Fixed a bug in the default grading system context - it was just not being picked up so it had nothing to do with our algorithm.

Added some help text when there is no community assigned grades which should make this less confusing.

Above changes are in repo.

The only thing left to close this issue is to confirm that Campbell is happy with the treatment of access to editing descendants versus children.

brendanheywood commented 12 years ago

When I added the 'bulk edit' button to the toolbar I specifically didn't want to edit all the descendants at least by default. I think this is a little dangerous but maybe I'm over cautious. I'd prefer to have this as a toggle once you are inside like the fields.

cgome commented 12 years ago

OK I think that works well now.

SHould the 'Edit Crag' button at the top also link to this page/proces now?

On Fri, May 11, 2012 at 7:12 PM, Brendan Heywood < reply@reply.github.com

wrote:

When I added the 'bulk edit' button to the toolbar I specifically didn't want to edit all the descendants at least by default. I think this is a little dangerous but maybe I'm over cautious. I'd prefer to have this as a toggle once you are inside like the fields.

Reply to this email directly or view it on GitHub: https://github.com/theCrag/website/issues/534#issuecomment-5646774

Campbell

scd commented 12 years ago

Your call Brendan.

brendanheywood commented 12 years ago

yup agree and it's done