theCrag / website

theCrag.com: Add your voice and help guide the development of the world's largest collaborative rock climbing & bouldering platform
https://www.thecrag.com/
110 stars 8 forks source link

ctrl + click on topo point does not emulate right click (Mac) #576

Closed SyntaxPickax closed 11 years ago

SyntaxPickax commented 12 years ago

It's not possible to edit topo points on a Mac laptop without connecting a 2-button mouse. Holding ctrl while clicking should be expected to perform a right click, but this feature does not seem to be supported when editing topos. Instead, ctrl + click is handled as a left-click.

(Things work just fine with an external 2-button mouse.)

Using Chrome 18.0.1025.168 on OS 10.7.4

brendanheywood commented 12 years ago

Note for myself, pretty sure this will do the job:

http://stackoverflow.com/questions/7251846/jquery-detecting-cmdclick-controlclick

SyntaxPickax commented 12 years ago

Oh good, I think you're right. Just a heads up though. The developer on stackoverflow seems to think "cmd + mouse left click (mac)" should emulate a right click, but it should actually be "ctrl + mouse left". This also appears to be answered here: http://stackoverflow.com/questions/2485345/javascript-or-jquery-event-handlers-for-ctrl-shift-mouse-left-button-click

brendanheywood commented 12 years ago

Cool thanks. I don't have a mac laptop (I dev on a iMac though) so you'll be my testing buddy when I get to this :)

SyntaxPickax commented 12 years ago

Great! Happy to help

SyntaxPickax commented 11 years ago

My external mouse just died. Any chance I can bump this one up in priority? :-) (Should be easy right?)

brendanheywood commented 11 years ago

hey Brandon can you do test whether this demo page works the way you want?:

http://medialize.github.com/jQuery-contextMenu/demo.html

SyntaxPickax commented 11 years ago

Yep, works great: ctrl + right-click brings up a context menu, while cmd+right-click and alt+right-click do nothing.

brendanheywood commented 11 years ago

Hmmm. Lot as simple as I thought, I'm probably going to have to replace the whole menu code with something newer, not a 10 minute job in my lunch break :(

SyntaxPickax commented 11 years ago

Ha, well let me know if/when you need me to test anything. (Hope I didn't ruin your lunch break!)

On Thu, Oct 11, 2012 at 5:37 PM, Brendan Heywood notifications@github.comwrote:

Hmmm. Lot as simple as I thought, I'm probably going to have to replace the whole menu code with something newer, not a 10 minute job in my lunch break :(

— Reply to this email directly or view it on GitHubhttps://github.com/theCrag/website/issues/576#issuecomment-9363265.

brendanheywood commented 11 years ago

I'm contemplating just removing the need for a context menu completely. We're still working out details for editing topos in the mobile app but obviously a right click there makes no sense there. Dragging a point should be a normal drag, maybe the points could be a long tap and hold. Needs more research and thinking

brendanheywood commented 11 years ago

Just a heads up that I'm embarking on a whole new rewrite which will need to work on touch devices and will probably mean getting rid of all menus and moving to an interface more like a drawing program, so I'm gonna close this.

brendanheywood commented 9 years ago

Heads up that in the next release this is now working well

SyntaxPickax commented 9 years ago

Huzzah.