theCrag / website

theCrag.com: Add your voice and help guide the development of the world's largest collaborative rock climbing & bouldering platform
https://www.thecrag.com/
109 stars 8 forks source link

Dogs showin up in ticks stats #973

Closed brendanheywood closed 9 years ago

brendanheywood commented 11 years ago

Just noticed on my profile in prod that I've done a V7 which I don't remember doing:

http://www.thecrag.com/climber/brendanheywood

image

If I edit that tick it is a dog:

image

This shouldn't be showing up as a 'tick'. This one is a bit funny as it's a bit semantic but it feels wrong. It is the very first thing that catches your eye at the top of the table and makes it seem like I'm really good which I aint.

Maybe the solution is something else like moving that row to the bottom and calling it 'Other ticks'. This also appears in all the other charts, in the other charts I think it should be filtered.

scd commented 11 years ago

But then I am not nearly as good as my chart suggest.

It definitely should not show up as your hardest lead.

When I get round to it this should be ok to fix as these are all done on the fly.

leemcdougall commented 11 years ago

I've always thought this too. Shouldn't be a tick. Its easily filtered out by selecting 'clean' ascents, but i dont think a non clean ascent should also be a tick to start off with.

scd commented 11 years ago

There are a number of things going on here

Dog in the Lead group

There was definitely a bug in the configuration, dogs should never have been in the Lead tick group, so this is fixed, on my server, but needs me to

Dog in general Tick group

Do we want to move the "Dog" from the general "Tick" group to the "Attempted Ascents" group? I am not comfortable with this, but a number of people have asked to remove their Dogs from their Tick stats in the profile page. This seems reasonable so in response I have hard coded the removal of Dog from the general Tick stat in the Profile Page. However it remains a 'Tick' for other parts of the site.

Top rope with rest and Second with rest in general Tick group

Similarly to Dog I have removed them from the general Tick group, as a hard code exclusion just in the Profile page.

Top rope clean and Second clean. in Clean group

Although they are technically 'Clean' routes, at least one person has asked me to remove them from their Clean group.

Merge Clean and Lead into one group called Lead.

If I was to remove top rope clean and second clean from the Clean group (as suggested above) then 'Clean' and 'Lead' groups become so similar that I might as well merge the two groups into one group called 'Lead'.

Hmmm, so this is actually 5 separate issues. Cool.

brendanheywood commented 11 years ago

I think the problem with the 'tick' group is that it's confused with the generic 'tick' tick type, and everyone has their own definition of what a tick means to them. So maybe it would be better to simply side step the problem and use language that's more indicative of the grouping. So not sure exactly but if the 'tick' group was more like 'I got the to top in whatever style' if would be less confusing. Maybe just 'Ascents' or 'All ticks'. I also think that all the groups should have plural names to make it clearer that they are the combination of many tick types, like this:

image

This way it is super obvious that All ticks is a superset of 'clean' or 'lead'.

Also does this set of decisions affect the way the ticks are grouped in the tick dropdowns around the place? ie:

image

In this context then Dog should still be a 'lead' tick

scd commented 11 years ago

The only decision that effects the other parts of the site was to remove Dog from Lead group. I sort of assumed that was a bug. It comes down to community accepted definitions, do people use Dog for top roping?

cgome commented 11 years ago

This is a really interesting one because it is pretty subjective and may have changed through time.

For me, a 'dog' means "I made it to the top but fell or rested on the way." Even if I rested, fell or pulled on gear while seconding or top-roping I'd still say that I dogged it- so in a way maybe we should've had Second Dog and TR Dog as tick types instead of 'with rest' all this time?

In any case I feel like Dog / with rest ascents should probably not be included in hardest stats.

On Fri, Mar 8, 2013 at 3:58 PM, Simon Dale notifications@github.com wrote:

The only decision that effects the other parts of the site was to remove Dog from Lead group. I sort of assumed that was a bug. It comes down to community accepted definitions, do people use Dog for top roping?

— Reply to this email directly or view it on GitHubhttps://github.com/theCrag/website/issues/973#issuecomment-14602833 .

Campbell

brendanheywood commented 11 years ago

Yeah it is very subjective. For me a dog is distinct to merely resting, it's almost aid climbing, pulling on gear, and batmanning, so I haven't done all the moves vs a 'lead with rests' where I've done every move.

Sent from my iPhone

On 08/03/2013, at 5:13 PM, cgome notifications@github.com wrote:

This is a really interesting one because it is pretty subjective and may have changed through time.

For me, a 'dog' means "I made it to the top but fell or rested on the way." Even if I rested, fell or pulled on gear while seconding or top-roping I'd still say that I dogged it- so in a way maybe we should've had Second Dog and TR Dog as tick types instead of 'with rest' all this time?

In any case I feel like Dog / with rest ascents should probably not be included in hardest stats.

On Fri, Mar 8, 2013 at 3:58 PM, Simon Dale notifications@github.com wrote:

The only decision that effects the other parts of the site was to remove Dog from Lead group. I sort of assumed that was a bug. It comes down to community accepted definitions, do people use Dog for top roping?

— Reply to this email directly or view it on GitHub< https://github.com/theCrag/website/issues/973#issuecomment-14602833> .

Campbell

— Reply to this email directly or view it on GitHubhttps://github.com/theCrag/website/issues/973#issuecomment-14604619 .

scd commented 11 years ago

given that we have had one member ask us to take it out of the lead section I think we should keep it out for a bit and see who complains.

The other thing we should think about is that the leaderboard should allign with the concepts in the profile page. This means it should probably be out in both places.

scd commented 11 years ago

My target list of filters:

cgome commented 11 years ago

Strictly speaking it should be sex (male/female), not gender (masculine/feminine).

But does using sex get us in trouble with filters, etc?

There's probably a political and practical dimension too-

http://en.wikipedia.org/wiki/Gender_verification_in_sports http://en.wikipedia.org/wiki/Third_gender http://en.wikipedia.org/wiki/Sex_assignment

I think for us Sex: Male/Female/ and maybe an unknown/not provided would suffice?

On Sat, Mar 9, 2013 at 9:28 AM, Simon Dale notifications@github.com wrote:

My target list of filters:

  • using-stat
  • from-country
  • not-from-country
  • at
  • after
  • before
  • between
  • with-tick-type
  • with-tick-group
  • with-gear-style
  • by # for a list of climbers
  • by-friends-of
  • at-followed-by
  • of-gender # not sure if this is the right phrasing
  • age-older
  • age-younger
  • age-between

— Reply to this email directly or view it on GitHubhttps://github.com/theCrag/website/issues/973#issuecomment-14649607 .

Campbell

scd commented 11 years ago

A lot of people will be using thecrag from work, and filters are not always good a recognising context. I don't think we lose anything by using the word gender rather than sex.

brendanheywood commented 11 years ago

rant url keyword filters are just stupid. At UNE we had a page which used a hash like md5 for the url. One particular page had a url like /rgwETHwv345sexETH which was blocked by some students work because it just happen to contain a bad word.

scd commented 11 years ago

so /sex/female is not going to work as a url for us.

scd commented 9 years ago

I think this is fixed