search

theCrius / tildes-extended

Extension for Chrome and Firefox to enhance the UX/UI of https://tildes.net
ISC License
14 stars 5 forks source link

LocalStorage limit exceeded #36

Open heliostatic opened 6 years ago

heliostatic commented 6 years ago

Can't apply the Dracula CSS in Chrome (with the Chrome specific dracula css)

Expected Behavior

Save successfully.

Current Behavior

Does not save successfully because the localStorage limit is exceeded for a single key.

Screenshots

screen shot 2018-06-26 at 10 55 02 am screen shot 2018-06-26 at 10 54 57 am

Steps to Reproduce

Fresh install of the extension, add single line of external CSS (listed above) to the extension, save, observe console error.

Environment

Mac OS 10.13 Chrome 67

Additional notes

theCrius commented 6 years ago

Yeah, I noticed issue with the size allowed as well.

We will change how Tildes Extended manage the styles. Right now everything is saved in storage.sync that has quite a low storage limit. We will move the styles into the storage.local instead that has a maximum limit of 5Mb. That should suffice for every possible stylesheet(s) a user want to load.

Reference: https://developer.chrome.com/extensions/storage#properties