theDavidCoen / LightningExchanges

List of exchanges that support Lightning Network
200 stars 51 forks source link

Distinguish between N/A and Unknown #70

Closed knocte closed 4 months ago

knocte commented 4 months ago

In the majority of cases, the cells marked with n.a didn't really mean "not applicable", but rather "unknown, please contribute the info", so I'm marking the latter with a question mark and adding a legend entry about it. Hopefully thanks to this, we get more contributions and the table gets more complete.

theDavidCoen commented 4 months ago

That's nice, but where there is NO in "Lightning Support?", please keep n.a. since is not applicable.

For instance, Coinbase is n.a. until we have someone who creates a PR to add Coinbase since it support Lightning now.

knocte commented 4 months ago

That's nice, but where there is NO in "Lightning Support?", please keep n.a. since is not applicable.

I did! For example, look at the BitHumb row. As it doesn't support LN, then I kept n.a. in all columns (except one, because we could also provide info about KYC regardless of their LN support status).

For instance, Coinbase is n.a. until we have someone who creates a PR to add Coinbase since it support Lightning now.

Precisely I did this with Coinbase because I know they support LN now! So then the question marks become "more inviting" to contributions.

theDavidCoen commented 4 months ago

Got it. Before merging, please update the repo because it's 2 commits behind.

theDavidCoen commented 4 months ago

Ok the PR has no more conflicts, however I ask you to leave n.a. at least for Coinbase. Then, after a PR that changes Coinbase fields, we can revisit that.

knocte commented 4 months ago

Ok, done.

theDavidCoen commented 4 months ago

@knocte can you update your repo first?

knocte commented 4 months ago

Done.

theDavidCoen commented 4 months ago

thanks!