Open orbea opened 4 years ago
I know this problem... I think one simple solution could be assuming that no weather goes below -200 nodes. That way weather could be disabled in caves. Also I do like your solution and maybe that is good enough. I will consider adding it.
I'm not fond of the simple solution of disabling all weather below -200 nodes, I have experienced this at above sea level in a hollowed out mountain as well.
I have added your sky access check in 4287714cc6f7353ade499d7ee2831f015cbbd121. Maybe I will improve it to fit better to different types of weather later.
Describe the bug
Underground weather is not entirely fixed when in a large enough open spaces.
The weather effects will constantly start and stop which is not only silly, but highly distracting.
To Reproduce
Expected behavior It would be nice if weather was disabled when there is no sky access or if there is sky access the weather particles would be restricted to to only nodes that had sky access.
Screenshots![rain](https://i.imgur.com/EMt591b.png)
Desktop (please complete the following information):
5.2.0
Additional context I tried this to solve the problem, but it feels incomplete.
The remaining problem is that if the there is any sky access there will be weather everywhere in the near vicinity of the sky access and not only under the open space. Maybe there is a way to recreate the minp/maxp values with only positions that have enough light?