theKashey / focus-lock

Gotcha! A11y util for scoping a focus.
MIT License
172 stars 17 forks source link

Added FocusOptions to setFocus function to allow users to pass preventScroll to setFocus #29

Closed abhimanyu-singh-uber closed 2 years ago

abhimanyu-singh-uber commented 2 years ago

fixes- https://github.com/theKashey/react-focus-lock/issues/162

@theKashey Please have a look at this. Thanks

codecov[bot] commented 2 years ago

Codecov Report

Merging #29 (ef064a2) into master (79a32c1) will decrease coverage by 0.25%. The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
- Coverage   82.71%   82.46%   -0.26%     
==========================================
  Files          20       20              
  Lines         324      325       +1     
  Branches       70       64       -6     
==========================================
  Hits          268      268              
- Misses         51       52       +1     
  Partials        5        5              
Impacted Files Coverage Δ
src/setFocus.ts 22.72% <40.00%> (-1.09%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 79a32c1...ef064a2. Read the comment docs.

theKashey commented 2 years ago

Looking good

abhimanyu-singh-uber commented 2 years ago

yay! Thanks @theKashey let me know when you released the package, I can then raise a PR to react-focus-lock too.

theKashey commented 2 years ago

0.10.1 released, jumping to https://github.com/theKashey/react-focus-lock/issues/162 No action is required from your side. Let me handle the merge train 🚂