search

theKashey / focus-lock

Gotcha! A11y util for scoping a focus.
MIT License
172 stars 17 forks source link

remove Array spread operator and Array.find #4

Closed mjss closed 6 years ago

mjss commented 6 years ago

Should fix #3 ES6 spread operator is nice but Babel requires Array.from to transpile it (http://babeljs.io/docs/usage/caveats/#polyfills). From our observation, the babel-transpiled code contains two ES6 methods: Array.from and Array.find. Refactoring the spread operator and Array.find can make this module support IE10+ without any polyfills.

theKashey commented 6 years ago

Oh, please excuse me, but I made all these changes in the morning, and just testing vue-lock before bulk release.

theKashey commented 6 years ago

I am not just very good in Vue, and having problems with a testing :)

theKashey commented 6 years ago

Could you double check that everything works as expected? And thank you. (and sorry for conflicts)

mjss commented 6 years ago

Great! I tested in our setup with IE10, v0.3.0 don't need the polyfills anymore :)

mjss commented 6 years ago

closing my PR

theKashey commented 6 years ago

Making things better is our duty.