search

theKashey / proxyequal

There is a bit more smart way to compare things, than a shallow equal.
MIT License
72 stars 7 forks source link

Performance Improvements #14

Open ScriptedAlchemy opened 5 years ago

ScriptedAlchemy commented 5 years ago

Hey Anton,

I've been looking over the code and spotted a few areas where we might be able to improve performance.

There's some small ideas I had based on chip architecture that should speed up loops (looping backwards is faster than forwards), as well as my understanding of how native methods have been implemented into the browser & what their performance is capable of (filter is slow)

Mind if I open a PR? Also, do you know if any specific areas where bottlenecks are occurring?

Would love to boost the benchmarks if possible :)

dai-shi commented 5 years ago

Hi @ScriptedAlchemy @theKashey Wouldn't it better to prepare a benchmark suite within this project? It should speed up the try-evaluate cycle and it'd be more comprehensive.

theKashey commented 5 years ago

That's a good idea. I had some benchmarks on memoize-state, the library this library was built for, but not here.

ScriptedAlchemy commented 5 years ago

I can look at creating some benchmark. What tools to you typically use for such things?

theKashey commented 5 years ago

🤔🤷‍♂️, js-perf