theKashey / react-focus-lock

It is a trap! A lock for a Focus. 🔓
MIT License
1.27k stars 67 forks source link

Does not use ownerDocument (doesn't work in new windows) #183

Closed LoganDark closed 1 year ago

LoganDark commented 2 years ago

I am searching for another library to solve this issue, but this library seems to have the exact same issue. This means I can't use it, but I would like to open this issue anyway so that maybe this functionality could be added.

theKashey commented 2 years ago

Got you. There is just a few places where we access document (usually document.activeElement) and it might be not the right owner of a current element managed by focus-lock.

In this terms this issue has a very direct connection with #188

stale[bot] commented 1 year ago

This issue has been marked as "stale" because there has been no activity for 2 months. If you have any new information or would like to continue the discussion, please feel free to do so. If this issue got buried among other tasks, maybe this message will reignite the conversation. Otherwise, this issue will be closed in 7 days. Thank you for your contributions so far.

LoganDark commented 1 year ago

Stale is the most useless possible bot. this issue still exists, not sure how I missed the stale bot being stupid, but this shouldn't have been closed.